DialogHost IsLoaded but not exactly #3804

Activity

1. jbooth88

   added

   bug

   evaluation requiredItems is pending review or evaluation by the teamItems is pending review or evaluation by the team

   on Mar 4, 2025
2. corvinsz commented on Mar 11, 2025

   

   corvinsz

   on Mar 11, 2025

   Last edited by corvinsz

   Member

   More actions

   FYI: As far as I can tell the problem is that the Show method is called before the Loaded event of the DialogHost is raised. Therefore the dialoghost instance has not yet been added to the LoadedInstances hashset.

   Executing the logic in the Onloaded method when the Initialized event is raised fixes this problem. I am however not confident that this is a suitable fix, because the DialogHost is quite a large class and it could possibly break something else.
   

   MaterialDesignInXamlToolkit/src/MaterialDesignThemes.Wpf/DialogHost.cs

   Line 288 in ae59e31

   Loaded += OnLoaded;

   public DialogHost()
   {
   -   Loaded += OnLoaded;
   +   Initialized += OnLoaded;
       Unloaded += OnUnloaded;
   
       CommandBindings.Add(new CommandBinding(CloseDialogCommand, CloseDialogHandler, CloseDialogCanExecute));
       CommandBindings.Add(new CommandBinding(OpenDialogCommand, OpenDialogHandler));
   }

   Edit: @jbooth88 if applicable and you need a quick & dirty fix you can just listen for the Loaded event on the DialogHost like so:

   public MainWindow()
   {
       InitializeComponent();
       myDialogHost.Loaded += MyDialogHost_Loaded;
   }
   private async void MyDialogHost_Loaded(object sender, RoutedEventArgs e) => await DialogHost.Show("test content", "RootDialog");
3. jbooth88 commented on Mar 11, 2025

   

   jbooth88

   on Mar 11, 2025

   ContributorAuthor

   More actions

   That is covered in "Scenario 3" in the sample project I provided. It works only if the DialogHost was not already loaded/initialized prior to the window constructor call (which I admit won't be a problem for most users).

   👍React with 👍1Reacted by Corvin
4. AmeerMansour commented on Mar 29, 2025

   

   AmeerMansour

   on Mar 29, 2025

   More actions

   @corvinsz
   can you please help me and check my issue as i am not expert in material design toolkit structure ?
   #3824