-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Closed
Labels
breaking changeItems here have breaking API changes.Items here have breaking API changes.release notesItems are likely to be highlighted in the release notes.Items are likely to be highlighted in the release notes.
Milestone
Description
There is an existing 5.0.0 branch where these changes are being made. Once we are a little closer to the release this branch will be merged into master. Anyone is welcome to pick up tasks here and PR into the 5.0.0 branch.
This is a list of proposed breaking changes for the 5.0.0 release. Feedback welcome!
- Remove
DrawerHostOpenMode.Model(Added in 4.0.0, Obsolete in 4.1.0) - Remove
MaterialDesignScrollBarThumbVerticalandMaterialDesignScrollBarThumbHorizontalreplace withMaterialDesignScrollBarThumb - Consider making recommended theme color classes static.
- Currently not possible because they implement the
ISwatchinterface.
- Currently not possible because they implement the
- Update ListBoxItem to use theme brush for hover color rather than deriving from the Foreground.
- Update MenuItem to use theme brush for hover color rather than deriving from the Foreground.
- There is a both usage of "Assist" and "Extensions" used. Consider standardizing on naming
- Remove
MaterialDesignRaisedAccentButtonin favor ofMaterialDesignRaisedSecondaryButton - Remove
MaterialDesignFlatAccentButtonin favor ofMaterialDesignFlatSecondaryButton - Remove
MaterialDesignFlatAccentBgButtonin favor ofMaterialDesignFlatSecondaryMidBgButton - Remove
MaterialDesignFloatingActionMiniAccentButtonin favor ofMaterialDesignFloatingActionMiniSecondaryButton - Remove
MaterialDesignFloatingActionAccentButtonin favor ofMaterialDesignFloatingActionSecondaryButton - Remove
ComboBoxPopupPlacement - Remove obsolete members from
ComboBoxPopup - Remove obsolete templates
PopupContentUpTemplateandPopupContentDownTemplate - Remove obsolete brushes Theme brush rename #2435
- Replace usages of "Accent" with "Secondary"
- Remove "MaterialDesignNavigatilRailTabControl" it is replaced by "MaterialDesignNavigationRailTabControl"
- Remove RatingBarButton.IsWithinSelectedValue property
- Remove obsolete members from
FlyoutAssist - Remove
ShadowDepth - Remove
ShadowAssist.ShadowEdges - Rename
ShadowEdgeConvertertoShadowOpacityMaskConverterto better reflect its usage - Ensure all styles and brushes that contain the word "Accent" have been replaced with "Secondary"
- Remove
PickerInnerPaddingConverter(obsolete in PR Additional SmartHint refactoring #3181) - Rename all *Mixin classes to be *Extensions
- Remove MaterialDesignTheme.Defaults.xaml in favor of people using either MaterialDesign2.Defaults.xaml or MaterialDesign3.Defaults.xaml
- Ensure all removed obsolete styles exist in the Obsolete shim resource dictionary.
- Remove
IThemein favor ofTheme - Remove
IBaseTheme. Its usages are replaced withThemeExtensions.SetBaseTheme()method.
RiddleTime and Mohammed-AlhawryInflactwf
Metadata
Metadata
Assignees
Labels
breaking changeItems here have breaking API changes.Items here have breaking API changes.release notesItems are likely to be highlighted in the release notes.Items are likely to be highlighted in the release notes.
Type
Projects
Status
Done