Feature/background #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Pilse
commented
Feb 9, 2021
Pilse
commented
- 기존 리눅스 쉘과 다른점: 백그라운드 실행이 완료되면 실제 쉘은 Enter키 등으로 출력버퍼를 비울 때 Done 메세지가 나오지만 이번 구현에서는 실행이 완료되면 바로 터미널에 출력이 됩니다.
- 궁금하신 것이나 잘못된 것 있으면 댓글 달아주시면 감사하겠습니다.
implementing background.c
UOSCS
reviewed
Feb 10, 2021
| if (flag_redirection) | ||
| ; | ||
| else if (flag_pipe) | ||
| process_pipe(arg, index, how); |
Member
There was a problem hiding this comment.
minishell프로그램이 process_pipe함수 내에서 background함수를 호출하면 어떻게 되나요?
Contributor
Author
There was a problem hiding this comment.
pipe나 redirection이 있는 명령어가 들어온다면 작동하지 않습니다. 그부분에 대해서는 나중에 얘기를 한번 해봐야 될 것 같습니다.
Member
There was a problem hiding this comment.
고생하셨습니다 OK
process_redir 관련한 수정사항은 브랜치로 merge하겠습니다
Dongdong351
added a commit
to Dongdong351/Linux-Shell-Project
that referenced
this pull request
Feb 17, 2021
Merge pull request Master-C-Programming#29 from Master-C-Programming/feature/background
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.