modified_command_line #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UOSCS
reviewed
Jan 9, 2021
| execvp(*arg,arg); | ||
| return true; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
함수를 끝내는 return이 산재해있다는 느낌이 들긴 하지만, OK입니다.
Member
There was a problem hiding this comment.
line 23 오타
change_direcory(arg); -> change_directory(arg);
There was a problem hiding this comment.
line 1,2,3 #include <...> 띄어쓰기 한번만 확인해주시면 좋을거같습니다.
Pilse
force-pushed
the
feature-command_line
branch
from
9ad091e to
f4321d1
Compare
UOSCS
reviewed
Jan 13, 2021
| { | ||
| return true; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
후에 if(type == ??)문 물음표 자리에 숫자 대신 상수 식별자만 들어가면 될 것 같습니다. OK
Member
There was a problem hiding this comment.
36~43 에서 is_redirection과 is_pipe로 리디렉션, 파이프 여부 검사하고 redirection(arg);과 pipe(arg);에서 자식 프로세스가 exec 하는 과정으로 생각하면 되나요
이 과정이 맞다면 OK입니다.
Member
There was a problem hiding this comment.
change_directory의 전달 인자를 change_directory(arg, index);로 수정 부탁드립니다.
사유 : index 값에 따라 cd 동작이 달라지게 하면 구현하기에 용이할 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-& 가 중간에 오면 parsing이 중단되는 점을 수정했습니다.
-호출하는 함수마다 index를 인자로 주어 arg의 크기를 알 수 있게 하였습니다.