MDEV-38801 Item_sum & Item_cache implement deep_copy() - #5536
Open
mariadb-RexJohnston wants to merge 1 commit into
Open
MDEV-38801 Item_sum & Item_cache implement deep_copy()#5536mariadb-RexJohnston wants to merge 1 commit into
mariadb-RexJohnston wants to merge 1 commit into
Conversation
{Item_cache,Item_cache_row,Item_sum}::deep_copy() currently call
shallow_copy_with_checks(). This causes issues when a proper
independent copy is required, e.g. in add_key_part called on a key
with a value containing an item inherited from Item_cache.
We implement a proper deep copy that shares no nodes with the source,
and add a check to ensure this.
mariadb-RexJohnston
force-pushed
the
11.8-MDEV-38801
branch
from
August 13, 2026 22:48
8e87851 to
eb33197
Compare
Member
Author
|
I had to update a few things here, the walk update tripped me up and i had to move the assert check out of Item::deep_copy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{Item_cache,Item_cache_row,Item_sum}::deep_copy() currently call shallow_copy_with_checks(). This causes issues when a proper independent copy is required, e.g. in add_key_part called on a key with a value containing an item inherited from Item_cache. We implement a proper deep copy that shares no nodes with the source, and add a check to the default Item::deep_copy_with_checks to ensure this.