MDEV-40728 Recovery wrongly fails if FILE_CREATE is followed by FILE_RENAME - #5530
Open
dr-m wants to merge 1 commit into
Open
MDEV-40728 Recovery wrongly fails if FILE_CREATE is followed by FILE_RENAME#5530dr-m wants to merge 1 commit into
dr-m wants to merge 1 commit into
Conversation
|
|
This was referenced Aug 11, 2026
dr-m
force-pushed
the
MDEV-40728
branch
2 times, most recently
from
August 13, 2026 05:27
36c544d to
48b8608
Compare
Thirunarayanan
approved these changes
Aug 13, 2026
Thirunarayanan
approved these changes
Aug 13, 2026
…RENAME fil_name_process(): Simplify the logic. If no matching tablespace is found but file_name_t::create_lsn had been set in response to parsing a FILE_CREATE record, try to apply FILE_RENAME to deferred_spaces. deferred_spaces.deferred_dblwr(): Skip newly created tablespaces to avoid a bogus invocation of fil_space_free(). fil_delete_apply(): Wrappers for fil_space_free(). When recovering a log in innodb_log_archive=ON format, we must apply FILE_DELETE records in order to avoid a future clash with FILE_CREATE or FILE_RENAME.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fil_name_process(): Simplify the logic. If no matching tablespace is found butfile_name_t::create_lsnhad been set in response to parsing aFILE_CREATErecord, try to applyFILE_RENAMEto deferred_spaces.deferred_spaces.deferred_dblwr(): Skip newly created tablespaces to avoid a bogus invocation offil_space_free().fil_delete_apply(): A wrapper forfil_space_free(). When recovering a log ininnodb_log_archive=ONformat, we must applyFILE_DELETErecords in order to avoid a future clash withFILE_CREATEorFILE_RENAME.