Skip to content

feat(tests): XML report with format#685

Merged
grooverdan merged 6 commits into
MariaDB:nextfrom
Times-Z:feature/issue-684-xml-test-suite
Apr 7, 2026
Merged

feat(tests): XML report with format#685
grooverdan merged 6 commits into
MariaDB:nextfrom
Times-Z:feature/issue-684-xml-test-suite

Conversation

@Times-Z
Copy link
Copy Markdown

@Times-Z Times-Z commented Apr 4, 2026

resolve #684

I created the XML format based on the example provided
I wasn't entirely sure what the combinations field was for, so I used it to store the name of the tested image

Here is an example of an XML where all tests passed, and another where a test failed

mtr-report_failed.xml
mtr-report_passed.xml

EDIT: Added it to the CI job artifacts as well, so you can see every run job

Copy link
Copy Markdown
Member

@grooverdan grooverdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for writing this.

I wasn't going to use it for github workflows, just for the buildbot per quick drat - MariaDB/buildbot#945. Can you omit the workflows change for now.

Comment thread .test/run.sh Outdated
;;
--xml)
xml_enabled=1
if [ $# -gt 1 ] && [ -n "$image" ] && [[ "$2" != -* ]]; then
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ mariadb-docker/.test/run.sh --xml /tmp/x.xml mariadb:latest
Error response from daemon: failed to find image tmp/x.xml: docker.io/tmp/x.xml: No such image

Its messy parsing this. Happy to just have the --xml=file.xml + --xml (and no args) syntax.

Comment thread .test/run.sh Outdated

escaped_name="$(xml_escape "$name")"
escaped_classname="$(xml_escape "$classname")"
escaped_combinations="$(xml_escape "$image")"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

combinations where a MTR concept where the same test was run with a different set of parameters. It can be omitted from this.

@grooverdan
Copy link
Copy Markdown
Member

Thanks for the quick update. I'll get some interop testing done in the next few days.

@grooverdan grooverdan merged commit 9417739 into MariaDB:next Apr 7, 2026
11 of 14 checks passed
@grooverdan
Copy link
Copy Markdown
Member

Thank you very much @Times-Z !

grooverdan added a commit to grooverdan/mariadb-buildbot that referenced this pull request Apr 7, 2026
Use the xml form of .test/run.sh to generate a cross reference
result. (MariaDB/mariadb-docker#685)

If the healthcheck fails on CR, produce a warning (exit 2).

Other errors are BB errors.
RazvanLiviuVarzaru pushed a commit to MariaDB/buildbot that referenced this pull request Apr 14, 2026
Use the xml form of .test/run.sh to generate a cross reference
result. (MariaDB/mariadb-docker#685)

If the healthcheck fails on CR, produce a warning (exit 2).

Other errors are BB errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants