General: Correctly detect large floats in is_serialized().

SergeyBiryukov · SergeyBiryukov · commit fad1821dd702 · 2019-08-05T13:54:43.000Z
Props killerbishop, donmhico, hoythan. Fixes #46570. git-svn-id: https://develop.svn.wordpress.org/trunk@45754 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-includes/functions.php b/src/wp-includes/functions.php
@@ -528,7 +528,7 @@ function is_serialized( $data, $strict = true ) {
 		case 'i':
 		case 'd':
 			$end = $strict ? '$' : '';
-			return (bool) preg_match( "/^{$token}:[0-9.E-]+;$end/", $data );
+			return (bool) preg_match( "/^{$token}:[0-9.E+-]+;$end/", $data );
 	}
 	return false;
 }
diff --git a/tests/phpunit/tests/functions.php b/tests/phpunit/tests/functions.php
@@ -229,6 +229,20 @@ function test_is_serialized() {
 		}
 	}
 
+	/**
+	 * @ticket 46570
+	 */
+	function test_is_serialized_should_return_true_for_large_floats() {
+		$cases = array(
+			serialize( 1.7976931348623157E+308 ),
+			serialize( array( 1.7976931348623157E+308, 1.23e50 ) )
+		);
+
+		foreach ( $cases as $case ) {
+			$this->assertTrue( is_serialized( $case ), "Serialized data: $case" );
+		}
+	}
+
 	/**
 	 * @ticket 17375
 	 */

Original file line number	Diff line number	Diff line change
`@@ -528,7 +528,7 @@ function is_serialized( $data, $strict = true ) {`
`528`	`528`	`case 'i':`
`529`	`529`	`case 'd':`
`530`	`530`	`$end = $strict ? '$' : '';`
`531`		`- return (bool) preg_match( "/^{$token}:[0-9.E-]+;$end/", $data );`
	`531`	`+ return (bool) preg_match( "/^{$token}:[0-9.E+-]+;$end/", $data );`
`532`	`532`	`}`
`533`	`533`	`return false;`
`534`	`534`	`}`