Customizer: Mixed priority sorting for panels and top-level sections.

nacin · nacin · commit bc582fc058a6 · 2014-08-14T04:42:30.000Z
props celloexpressions. fixes #28979. git-svn-id: https://develop.svn.wordpress.org/trunk@29488 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-admin/css/customize-controls.css b/src/wp-admin/css/customize-controls.css
@@ -132,7 +132,7 @@ body {
 }
 
 #customize-theme-controls .control-section:last-of-type.open,
-#customize-theme-controls .control-section:last-of-type .accordion-section-title {
+#customize-theme-controls .control-section:last-of-type > .accordion-section-title {
 	border-bottom-color: #ddd;
 }
 
diff --git a/src/wp-admin/customize.php b/src/wp-admin/customize.php
@@ -161,11 +161,8 @@
 
 			<div id="customize-theme-controls"><ul>
 				<?php
-				foreach ( $wp_customize->panels() as $panel ) {
-					$panel->maybe_render();
-				}
-				foreach ( $wp_customize->sections() as $section ) {
-					$section->maybe_render();
+				foreach ( $wp_customize->containers() as $container ) {
+					$container->maybe_render();
 				}
 				?>
 			</ul></div>
diff --git a/src/wp-includes/class-wp-customize-manager.php b/src/wp-includes/class-wp-customize-manager.php
@@ -43,10 +43,11 @@ final class WP_Customize_Manager {
 	 */
 	public $widgets;
 
-	protected $settings = array();
-	protected $panels   = array();
-	protected $sections = array();
-	protected $controls = array();
+	protected $settings   = array();
+	protected $containers = array();
+	protected $panels     = array();
+	protected $sections   = array();
+	protected $controls   = array();
 
 	protected $nonce_tick;
 
@@ -305,6 +306,17 @@ public function controls() {
 		return $this->controls;
 	}
 
+	/**
+	 * Get the registered containers.
+	 *
+	 * @since 4.0.0
+	 *
+	 * @return array
+	 */
+	public function containers() {
+		return $this->containers;
+	}
+
 	/**
 	 * Get the registered sections.
 	 *
@@ -891,6 +903,10 @@ public function prepare_controls() {
 			$panels[] = $panel;
 		}
 		$this->panels = $panels;
+
+		// Sort panels and top-level sections together.
+		$this->containers = array_merge( $this->panels, $this->sections );
+		uasort( $this->containers, array( $this, '_cmp_priority' ) );
 	}
 
 	/**
diff --git a/src/wp-includes/class-wp-customize-widgets.php b/src/wp-includes/class-wp-customize-widgets.php
@@ -434,8 +434,9 @@ public function customize_register() {
 		}
 
 		$this->manager->add_panel( 'widgets', array(
-			'title' => __( 'Widgets' ),
+			'title'       => __( 'Widgets' ),
 			'description' => __( 'Widgets are independent sections of content that can be placed into widgetized areas provided by your theme (commonly called sidebars).' ),
+			'priority'    => 110,
 		) );
 
 		foreach ( $sidebars_widgets as $sidebar_id => $sidebar_widget_ids ) {

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ body {`
`132`	`132`	`}`
`133`	`133`
`134`	`134`	`#customize-theme-controls .control-section:last-of-type.open,`
`135`		`-#customize-theme-controls .control-section:last-of-type .accordion-section-title {`
	`135`	`+#customize-theme-controls .control-section:last-of-type > .accordion-section-title {`
`136`	`136`	`border-bottom-color: #ddd;`
`137`	`137`	`}`
`138`	`138`
Original file line number	Diff line number	Diff line change
`@@ -434,8 +434,9 @@ public function customize_register() {`
`434`	`434`	`}`
`435`	`435`
`436`	`436`	`$this->manager->add_panel( 'widgets', array(`
`437`		`- 'title' => __( 'Widgets' ),`
	`437`	`+ 'title' => __( 'Widgets' ),`
`438`	`438`	`'description' => __( 'Widgets are independent sections of content that can be placed into widgetized areas provided by your theme (commonly called sidebars).' ),`
	`439`	`+ 'priority' => 110,`
`439`	`440`	`) );`
`440`	`441`
`441`	`442`	`foreach ( $sidebars_widgets as $sidebar_id => $sidebar_widget_ids ) {`