Truly check for ! empty() instead of falsey '' when determining whether to add LIMIT clause to SQL in wp_get_archives().

staylor · staylor · commit aa34ede22615 · 2014-05-23T18:27:10.000Z
Props jjeaton for the initial patch. Fixes #27834. git-svn-id: https://develop.svn.wordpress.org/trunk@28560 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-includes/general-template.php b/src/wp-includes/general-template.php
@@ -1192,7 +1192,7 @@ function wp_get_archives( $args = '' ) {
 		$r['type'] = 'monthly';
 	}
 
-	if ( '' != $r['limit'] ) {
+	if ( ! empty( $r['limit'] ) ) {
 		$r['limit'] = absint( $r['limit'] );
 		$r['limit'] = ' LIMIT ' . $r['limit'];
 	}

Original file line number	Diff line number	Diff line change
`@@ -1192,7 +1192,7 @@ function wp_get_archives( $args = '' ) {`
`1192`	`1192`	`$r['type'] = 'monthly';`
`1193`	`1193`	`}`
`1194`	`1194`
`1195`		`- if ( '' != $r['limit'] ) {`
	`1195`	`+ if ( ! empty( $r['limit'] ) ) {`
`1196`	`1196`	`$r['limit'] = absint( $r['limit'] );`
`1197`	`1197`	`$r['limit'] = ' LIMIT ' . $r['limit'];`
`1198`	`1198`	`}`