Site Health: Disable recommendations that could be problematic on multisite installs.

desrosj · desrosj · commit 62645be17ee3 · 2019-05-01T18:07:46.000Z
When viewing Site Health for a multisite install, there are a few recommendations that are not appropriate and could have negative implications for other sites on the install if the administrator follows the advice provided. For example, Site Health recommends that inactive plugins and themes for a site should be removed. On a single site install, this is a great recommendation. However, on a multisite install, inactive plugins and themes for one site should not be removed because they could be active for other sites on the network. This change also disables the `test_wp_version_check_attached()` test for multisite. This test checks for the presence of the `wp_version_check()` function on the `wp_version_check` hook, which is not present for every site on multisite. Reviewed by jeremyfelt and desrosj. Props iandunn, Clorith, azaozz, jeremyfelt. Fixes #47084. git-svn-id: https://develop.svn.wordpress.org/trunk@45275 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-admin/includes/class-wp-site-health-auto-updates.php b/src/wp-admin/includes/class-wp-site-health-auto-updates.php
@@ -86,6 +86,10 @@ public function test_constants( $constant, $value ) {
 	 * @return array The test results.
 	 */
 	public function test_wp_version_check_attached() {
+		if ( ! is_main_site() ) {
+			return;
+		}
+
 		$cookies = wp_unslash( $_COOKIE );
 		$timeout = 10;
 		$headers = array(
diff --git a/src/wp-admin/includes/class-wp-site-health.php b/src/wp-admin/includes/class-wp-site-health.php
@@ -366,7 +366,7 @@ public function get_test_plugin_version() {
 		}
 
 		// Check if there are inactive plugins.
-		if ( $plugins_total > $plugins_active ) {
+		if ( $plugins_total > $plugins_active && ! is_multisite() ) {
 			$unused_plugins = $plugins_total - $plugins_active;
 
 			$result['status'] = 'recommended';
@@ -521,7 +521,7 @@ public function get_test_theme_version() {
 			}
 		}
 
-		if ( $has_unused_themes && $show_unused_themes ) {
+		if ( $has_unused_themes && $show_unused_themes && ! is_multisite() ) {
 
 			// This is a child theme, so we want to be a bit more explicit in our messages.
 			if ( $active_theme->parent() ) {

Original file line number	Diff line number	Diff line change
`@@ -366,7 +366,7 @@ public function get_test_plugin_version() {`
`366`	`366`	`}`
`367`	`367`
`368`	`368`	`// Check if there are inactive plugins.`
`369`		`- if ( $plugins_total > $plugins_active ) {`
	`369`	`+ if ( $plugins_total > $plugins_active && ! is_multisite() ) {`
`370`	`370`	`$unused_plugins = $plugins_total - $plugins_active;`
`371`	`371`
`372`	`372`	`$result['status'] = 'recommended';`
`@@ -521,7 +521,7 @@ public function get_test_theme_version() {`
`521`	`521`	`}`
`522`	`522`	`}`
`523`	`523`
`524`		`- if ( $has_unused_themes && $show_unused_themes ) {`
	`524`	`+ if ( $has_unused_themes && $show_unused_themes && ! is_multisite() ) {`
`525`	`525`
`526`	`526`	`// This is a child theme, so we want to be a bit more explicit in our messages.`
`527`	`527`	`if ( $active_theme->parent() ) {`