msDBFOpenVirtualFile(): validate field extents against record length - #7571
Open
nvxbug wants to merge 1 commit into
Open
msDBFOpenVirtualFile(): validate field extents against record length#7571nvxbug wants to merge 1 commit into
nvxbug wants to merge 1 commit into
Conversation
A .dbf header whose field offsets and sizes exceed the record length made msDBFReadAttribute() strncpy past the record buffer on the first attribute read. Reject such a header at open, as shapelib does.
Contributor
Author
|
any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
AddressSanitizer, reading the first attribute of a shapefile whose
.dbfheader declares a field wider than its records:msDBFOpenVirtualFile()takesnRecordLengthfrom the header (bytes 10-11) to sizepszCurrentRecord, but each field'spanFieldSize/panFieldOffsetcome from the field descriptors with no check that they fit inside the record.msDBFReadAttribute()laterstrncpyspanFieldSizebytes frompabyRec + panFieldOffset, so a header whose fields do not fit the record reads past the record buffer on any attribute access (WFS GetFeature, joins, attribute-driven labels).Reject the file at open time when the last field's offset+size exceeds
nRecordLength, the same layout check shapelib applies. Valid.dbffiles satisfyoffset+size == nRecordLengthfor the last field, so they are unaffected. The added unit test covers both the rejected and the accepted case.What are related issues/pull requests?
None.
AI tool usage
Tasklist