Oracle: add subquery to apply sortBy before rownum paging - #7463#7464
Open
JamieIdox wants to merge 7 commits intoMapServer:mainfrom
Open
Oracle: add subquery to apply sortBy before rownum paging - #7463#7464JamieIdox wants to merge 7 commits intoMapServer:mainfrom
JamieIdox wants to merge 7 commits intoMapServer:mainfrom
Conversation
Author
|
Thank you! 🙏 |
jmckenna
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the main query is contained in the inner btmp sub query, rownum is moved to outside that query so that it is applied after the inner ORDER BY. I have tried to keep this change as simple as possible just by rearranging the existing code.
I am slightly concerned that we are missing a trailing AND from the removed code.
I have not been able to test or even build this as I don't have a build environment.