Use hard-coded FD for stdio in subprocess#390
Merged
Conversation
fantix
force-pushed
the
t136-use-stdio-fd
branch
from
February 9, 2021 01:47
ca69eab to
15ead44
Compare
This aligns uvloop with the same behavior in asyncio - when stdin, stdout or stderr is None, the subprocess will use FD 0, 1 or 2 now instead of sys.stdin, sys.stdout or sys.stderr. Fixes MagicStack#136
fantix
force-pushed
the
t136-use-stdio-fd
branch
from
February 9, 2021 02:37
15ead44 to
34cdeb6
Compare
fantix
marked this pull request as ready for review
February 9, 2021 02:57
1st1
approved these changes
Feb 9, 2021
Member
This is news to me... |
Member
Author
|
Well yeah - looks like it's not strictly FD 0/1/2 but rather a simple |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use FD=0/1/2 for
subprocess(stdin=None, stdout=None, stderr=None). This aligns uvloop with the same behavior in asyncio - when stdin, stdout or stderr is None, the subprocess will use FD 0, 1 or 2 now instead ofsys.stdin,sys.stdoutorsys.stderr.asyncio eventually calls this to create subprocess, where
p2cread,c2pwriteorerrwriteare-1and the current FD 0, 1 and 2 are left untouched to eventually callexecv().Fixes #136