forcely add UV_HANDLE_READABLE on pipe_t#342
Merged
Merged
Conversation
fantix
force-pushed
the
t317-readable-wronly-pipe
branch
2 times, most recently
from
May 9, 2020 21:02
39cd41f to
90b9e7f
Compare
fantix
marked this pull request as ready for review
May 9, 2020 22:55
1st1
reviewed
May 13, 2020
* in order to detect peer close on O_WRONLY pipe_t * partially reverted d8fe153 * refs libuv/libuv#2058 * refs MagicStack#317 * fixes MagicStack#311, fixes MagicStack#312
fantix
force-pushed
the
t317-readable-wronly-pipe
branch
from
May 13, 2020 20:33
90b9e7f to
88f9712
Compare
1st1
approved these changes
May 14, 2020
1st1
left a comment
1st1
left a comment
Member
There was a problem hiding this comment.
Sigh. Hopefully they fix the API.
Member
|
Great job, Fantix. |
Contributor
|
cool! appreciate you included my commit! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.