Add pool_timeout parameter to prevent pool operation hangs (#431)#1273
Open
ermakov-oleg wants to merge 1 commit intoMagicStack:masterfrom
Open
Add pool_timeout parameter to prevent pool operation hangs (#431)#1273ermakov-oleg wants to merge 1 commit intoMagicStack:masterfrom
ermakov-oleg wants to merge 1 commit intoMagicStack:masterfrom
Conversation
Contributor
Author
|
Hey @elprans! What do you think about this change? Would appreciate your input. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds pool_timeout parameter to Pool and create_pool() to prevent indefinite hangs in pool operations.
Problem
Pool operations could hang indefinitely, particularly during connection cleanup and cancellation (issue #431).
Solution
Changes