Open
Conversation
Address type introspection failures with QuestDB due to its lack of recursive CTE support. This primarily impacts types not built into asyncpg, such as float8[]. This commit: - Automatically registers float8[] when connected to QuestDB. - Disables certain features like advisory locks, which are not supported. - Notes that JIT, while used by QuestDB, cannot be disabled via its SQL API.
Author
|
Hello, This is my first pull request to asyncpg, and I would greatly appreciate any feedback or guidance. An alternative implementation could involve customizing the introspection queries to avoid recursive CTEs when QuestDB is detected. Since QuestDB's type system is relatively simple and lacks many PostgreSQL concepts, this should be feasible. However, I opted for the current approach as I believe it's not only simpler but also saves a network roundtrip. |
Member
|
It's probably worth looking into possibly adding a simpler variant of the introspection query for implementations that lack recursive CTE support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address type introspection failures with QuestDB due to its lack of recursive CTE support. This primarily impacts types not built into asyncpg, such as float8[].
This commit: