Fixes limiting on redi k33 #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mark-petersen we had originally put k33 before limiting slopes to have stronger diffusion for stability, but testing in E3SM has shown it creates too much mixing and overly deep boundary layers. This PR moves the k33 calculation post limiting to reduce the associated vertical mixing. I have not run into any stability issues with this change (30 years of G-case and 40 years of B-case). |
Contributor
Author
|
I will run the nightly soon and post results. |
on the vertical redi term, the surface scaling is currently being applied twice. This PR removes that. It also reorganizes the code to increase the strength of slope limiting on k33.
Contributor
|
Rebased, tested on grizzly with gnu and intel 19, debug and optimized. Passes nightly regression suite. |
mark-petersen
force-pushed
the
ocean/alterRediK33Limiting
branch
from
30d2c0f to
6b92c01
Compare
mark-petersen
approved these changes
Sep 10, 2020
Contributor
mark-petersen
left a comment
mark-petersen
left a comment
There was a problem hiding this comment.
@vanroekel please check this last commit. Otherwise, this is ready to merge.
Contributor
Author
|
@mark-petersen looks good. Thanks for taking out the extra calculation. |
mark-petersen
added a commit
that referenced
this pull request
Sep 10, 2020
Fixes limiting on redi k33 #684 on the vertical redi term, the surface scaling is currently being applied twice. This PR removes that. It also reorganizes the code to increase the strength of slope limiting on k33.
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Sep 14, 2020
This PR brings in a new mpas-source submodule with changes only to the ocean core, plus scripts updates corresponding to Registry changes in the ocean. It includes three changes to improve ocean heat uptake: * Fixes limiting on redi k33 (MPAS-Dev/MPAS-Model/pull/684); * Fixes surface buoyancy forcing calculation (MPAS-Dev/MPAS-Model/pull/690); and * Revert GM buoyancy gradient calculation to v1 form (MPAS-Dev/MPAS-Model/pull/687). [NML] [non-BFB]
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Sep 15, 2020
Update mpas-source: GM/Redi and surface buoyancy fixes This PR brings in a new mpas-source submodule with changes only to the ocean core, plus scripts updates corresponding to Registry changes in the ocean. It includes three changes to improve ocean heat uptake: * Fixes limiting on redi k33 (MPAS-Dev/MPAS-Model/pull/684); * Fixes surface buoyancy forcing calculation (MPAS-Dev/MPAS-Model/pull/690); and * Revert GM buoyancy gradient calculation to v1 form (MPAS-Dev/MPAS-Model/pull/687). [NML] [non-BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on the vertical redi term, the surface scaling is currently being
applied twice. This PR removes that. It also reorganizes the code to
increase the strength of slope limiting on k33.