Skip to content

Update Earth radius to the CIME value #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mark-petersen merged 24 commits into from
Sep 3, 2020
Merged

Update Earth radius to the CIME value #680

mark-petersen merged 24 commits into from
Sep 3, 2020

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Sep 1, 2020 •
edited
Loading

Currently, COMPASS uses 3 different Earth radii. With this merge and a corresponding update to MPAS-Tools, all Earth radii are the CIME value.

This PR addresses #549 along with MPAS-Dev/MPAS-Tools#341.

xylar added 24 commits August 28, 2020 21:16
@xylar
Update shared global_ocean configs and templates
1b92585
@xylar
Update shared hurricane configs
aede28c
@xylar
Update QU240
cd4b7ec
@xylar
Update QU240wISC
1ae5006
@xylar
Update ARM60to10
97919aa
@xylar
Update WC12
6b2c43d
@xylar
Update EC60to30
36ff26f
@xylar
Update EC60to30wISC
5479a5a
@xylar
Update SO60to10wISC
96c3672
@xylar
Update coastal/Maine
5b1aa84
@xylar
Update coastal/USDEQU120cr10rr2
f71a936
@xylar
Update Gaussian_hump/USDEQU120cr10rr2
c93e736
@xylar
Update WC14
8a416f8
@xylar
Update CA120to3
cf1a7fe
@xylar
Update HI120to12
aa08c72
@xylar
Update hurricane/USDEQU60at15cr5rr1
5da2266
@xylar
Update hurricane/USDEQU120at30cr10rr2
c600ff8
@xylar
Update USDEQU60at15cr5rr1WD and _veg
04ffdf8
@xylar
Update USDEQU120at30cr10rr2WD and _veg
2d6cf30
@xylar
Update USDEQU240at60cr20rr4, WD and WD_veg
5f1561c
@xylar
Update USDEQU60at15cr5rr*WD
2433e0d
@xylar
Update tides/USDEQU120at30cr10
83d114c
@xylar
Switch to old Earth radius for signed distance
cdbca9c
@xylar
Update Earth radius to the CIME value
1e89dfc
@xylar xylar changed the title Ocean/consistent compass earth radius @xylar Update Earth radius to the CIME value Sep 1, 2020
@xylar xylar changed the title @xylar Update Earth radius to the CIME value Update Earth radius to the CIME value Sep 1, 2020
@xylar
Copy link
Collaborator Author

xylar commented Sep 1, 2020

@mark-petersen and @sbrus89, this PR will be rebased once #577 is merged. This PR is needed before #668, #669, and #671 can go in, so it is also a priority.

@xylar
Copy link
Collaborator Author

xylar commented Sep 1, 2020

These changes are not bit-for-bit so I could use some help thinking about how to test them.

@xylar
Copy link
Collaborator Author

xylar commented Sep 1, 2020 •
edited
Loading

Testing on Grizzly

Verification that the test runs to completion:

  • Gaussian_hump/USDEQU120cr10rr2/build_mesh/
  • coastal/Maine/init
  • coastal/USDEQU120cr10rr2/build_mesh
  • global_ocean/ARM60to10/init
  • global_ocean/CA120to3/build_mesh
  • global_ocean/EC60to30/init
  • global_ocean/EC60to30wISC/init
  • global_ocean/HI120to12/build_mesh
  • global_ocean/QU240/init
  • global_ocean/QU240wISC/init
  • global_ocean/SO60to10wISC/init
  • global_ocean/WC12/init
  • global_ocean/WC14/init
  • hurricane/USDEQU120at30cr10rr2/build_mesh
  • hurricane/USDEQU120at30cr10rr2WD/build_mesh
  • hurricane/USDEQU120at30cr10rr2WD_veg/build_mesh
  • hurricane/USDEQU240at60cr20rr4/build_mesh
  • hurricane/USDEQU240at60cr20rr4WD/build_mesh
  • hurricane/USDEQU240at60cr20rr4WD_veg/build_mesh
  • hurricane/USDEQU60at15cr5rr1/build_mesh
  • hurricane/USDEQU60at15cr5rr1WD/build_mesh
  • hurricane/USDEQU60at15cr5rr1WD_veg/build_mesh
  • hurricane/USDEQU60at15cr5rr500WD/build_mesh
  • tides/USDEQU120at30cr10/build_mesh

@xylar
Copy link
Collaborator Author

xylar commented Sep 1, 2020

global_ocean/SO60to10wISC/init is failing during SSH adjustment. I wonder if this might be related to #676. I'm going to see if it works with a test merge of that PR.

mark-petersen
mark-petersen approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #577 (review)

@mark-petersen
Copy link
Contributor

mark-petersen commented Sep 3, 2020

Yes, I cherry-picked #676 for spin-up steps. I'll get that one on soon.

@mark-petersen mark-petersen mentioned this pull request Sep 3, 2020
Merged
26 tasks
@mark-petersen
Copy link
Contributor

mark-petersen commented Sep 3, 2020

See initial state plots: #577 (comment)

@mark-petersen mark-petersen mentioned this pull request Sep 3, 2020
Merged
sbrus89
sbrus89 approved these changes Sep 3, 2020
View reviewed changes
Copy link

@sbrus89 sbrus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, based on inspection of hurricane/USDEQU240at60cr20rr4WD case.

@mark-petersen mark-petersen merged commit dae055e into MPAS-Dev:ocean/develop Sep 3, 2020
This was referenced Sep 4, 2020
Merged
Merged
Merged
Closed
@xylar xylar deleted the ocean/consistent_compass_earth_radius branch September 4, 2020 09:22
@xylar
Copy link
Collaborator Author

xylar commented Sep 4, 2020

Thanks very much @sbrus89 and @mark-petersen for the review.

@xylar xylar mentioned this pull request Sep 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mark-petersen mark-petersen mark-petersen approved these changes

+1 more reviewer

@sbrus89 sbrus89 sbrus89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mark-petersen mark-petersen

Labels

COMPASS Ocean

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xylar @mark-petersen @sbrus89 @matthewhoffman