fixed bad continuation character in ocn init tidal boundary#675
Merged
mark-petersen merged 1 commit intoMPAS-Dev:ocean/developfrom Sep 8, 2020
philipwjones:ocean/tideInitContinuationBug
Merged
fixed bad continuation character in ocn init tidal boundary#675mark-petersen merged 1 commit intoMPAS-Dev:ocean/developfrom philipwjones:ocean/tideInitContinuationBug
mark-petersen merged 1 commit intoMPAS-Dev:ocean/developfrom
philipwjones:ocean/tideInitContinuationBug
Conversation
mattdturner
approved these changes
Sep 1, 2020
sbrus89
approved these changes
Sep 1, 2020
sbrus89
left a comment
sbrus89
left a comment
There was a problem hiding this comment.
Thanks for catching this, @philipwjones.
mark-petersen
added a commit
that referenced
this pull request
Sep 8, 2020
…develop fixed bad continuation character in ocn init tidal boundary #675
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Sep 8, 2020
Update MPAS-Source: fix Rayleigh damping and line continuation This PR brings in a new mpas-source submodule with changes only to the ocean core. The changes are for two bug fixes: * fix Rayleigh drag logic on implicit vertical mix, which only impacts standalone MPAS ocean spin-up simulations (MPAS-Dev/MPAS-Model/pull/676); and * fix bad continuation character in ocn init tidal boundary (MPAS-Dev/MPAS-Model/pull/675) [BFB]
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Sep 9, 2020
Update MPAS-Source: fix Rayleigh damping and line continuation This PR brings in a new mpas-source submodule with changes only to the ocean core. The changes are for two bug fixes: * fix Rayleigh drag logic on implicit vertical mix, which only impacts standalone MPAS ocean spin-up simulations (MPAS-Dev/MPAS-Model/pull/676); and * fix bad continuation character in ocn init tidal boundary (MPAS-Dev/MPAS-Model/pull/675) [BFB]
mark-petersen
added a commit
to mark-petersen/MPAS-Model
that referenced
this pull request
Jan 11, 2021
…to ocean/develop fixed bad continuation character in ocn init tidal boundary MPAS-Dev#675 In the ocn_init_tidal_boundary.F routine, there was a line with a bad continuation character (backslash instead of "&"). This is a single character replacement with the proper continuation character. Fixes MPAS-Dev#674
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the ocn_init_tidal_boundary.F routine, there was a line with a bad continuation character (backslash instead of "&"). This is a single character replacement with the proper continuation character.
Fixes #674