Change block tests to partition tests for QU240 RK4 and SE #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I was testing #550 and found that these test cases don't work anymore. |
xylar
changed the title
mark-petersen
force-pushed
the
ocean/remove_block_test
branch
from
997583f to
fadacf8
Compare
Contributor
|
@xylar, the previous block tests also served as a test for different domain partitions. So I simply changed these two tests to function again with partitions (4 vs 8). |
mark-petersen
approved these changes
Sep 9, 2020
Contributor
mark-petersen
left a comment
mark-petersen
left a comment
There was a problem hiding this comment.
Tested nightly regression suite with gnu on grizzly. Partition test with SE and RK4 work fine.
Contributor
|
@xylar If you agree with this, I'll merge. |
mark-petersen
changed the title
xylar
commented
Sep 9, 2020
Collaborator
Author
xylar
left a comment
xylar
left a comment
There was a problem hiding this comment.
I can't approve my own PR but I ran with the changes you made, @mark-petersen, and it works fine.
Probably a cleaner procedure in the future would be to just open a new PR, since this branch contains only changes that you made, is now incorrectly named, and I am not able to review it.
Collaborator
Author
|
I ran the two modified tests on my laptop with Gnu and they work as expected. |
Contributor
|
Yeah, looking back at this now, it would have been cleaner with two PRs. I'll keep that in mind on future ones. |
mark-petersen
added a commit
that referenced
this pull request
Sep 9, 2020
New Mesh: EC30to60kmL60E3SMv2r02 and change to 60 layers as default #668 New mesh: EC30to60kmL60E3SMv2r03 and change to gebco bathymetry #669 Fix validation for QU240 test step #660 Change block tests to partition tests for QU240 RK4 and SE #657 Update to version 0.1.11 of the compass environment #688
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Sep 9, 2020
Update MPAS-Source: COMPASS and documentation only This PR brings in a new mpas-source submodule with changes only to the ocean core. The changes are limited to internal coupling and documentation so it should have no impact on E3SM. It includes: * new EC30to60kmL60E3SMv2r02 mesh with 60 layers as default (MPAS-Dev/MPAS-Model/pull/668) * new EC30to60kmL60E3SMv2r03 mesh with change to gebco bathymetry (MPAS-Dev/MPAS-Model/pull/669) * switch from Travis-CI to Azure Pipelines (MPAS-Dev/MPAS-Model/pull/681) * fix validation for QU240 test step (MPAS-Dev/MPAS-Model/pull/660) * change block tests to partition tests for QU240 RK4 and SE (MPAS-Dev/MPAS-Model/pull/657) * update to version 0.1.11 of the compass environment (MPAS-Dev/MPAS-Model/pull/688) [BFB]
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Sep 10, 2020
pdate MPAS-Source: COMPASS and documentation only This PR brings in a new mpas-source submodule with changes only to the ocean core. The changes are limited to internal coupling and documentation so it should have no impact on E3SM. It includes: * new EC30to60kmL60E3SMv2r02 mesh with 60 layers as default (MPAS-Dev/MPAS-Model/pull/668) * new EC30to60kmL60E3SMv2r03 mesh with change to gebco bathymetry (MPAS-Dev/MPAS-Model/pull/669) * switch from Travis-CI to Azure Pipelines (MPAS-Dev/MPAS-Model/pull/681) * fix validation for QU240 test step (MPAS-Dev/MPAS-Model/pull/660) * change block tests to partition tests for QU240 RK4 and SE (MPAS-Dev/MPAS-Model/pull/657) * update to version 0.1.11 of the compass environment (MPAS-Dev/MPAS-Model/pull/688) [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #496, MPAS-Ocean no longer supports multiple blocks.