Skip to content

Fix path to docs in Travis CI#644

Merged
mark-petersen merged 1 commit intoMPAS-Dev:developfrom
xylar:fix_docs_path
Aug 17, 2020
Merged

Fix path to docs in Travis CI#644
mark-petersen merged 1 commit intoMPAS-Dev:developfrom
xylar:fix_docs_path

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Aug 4, 2020

Replace space (not backslash) with underscore in the path.

Documentation for "latest coastal" and "lastest ocean" is being
placed in a directory that is not very convenient to reference.

@xylar
Fix path to docs in Travis CI
8096d99 
Replace space (not backslash) with underscore in the path.

Documentation for "latest coastal" and "lastest ocean" is being
placed in a directory that is not very convenient to reference.
@xylar xylar added the CI only Changes only affect Azure Pipelines CI, not the code or documentation label Aug 4, 2020
@xylar xylar requested review from mark-petersen and sbrus89 August 4, 2020 06:17
@xylar
Copy link
Collaborator Author

xylar commented Aug 4, 2020

@mark-petersen and @sbrus89, I noticed that recent merges put documentation here:
http://mpas-dev.github.io/MPAS-Model/latest%20coastal/
and here:
http://mpas-dev.github.io/MPAS-Model/latest%20ocean/

I made a small mistake and the space should have been replaced with an underscore. I'm mostly asking for your review to confirm that you think this change will fix the problem, since it's not very easy to test.

@xylar
Copy link
Collaborator Author

xylar commented Aug 4, 2020

This fix won't propagate to ocean/develop or ocean/coastal for awhile so we'll just have to live with the bad path for awhile.

mark-petersen
mark-petersen approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar, since this is only a single character change and only for travis_ci, I'm happy to merge it in today, then develop into ocean/develop, and we can see if it works. From a web search, I see %20 in a web address is a space. I don't understand where the space comes from originally, but it sure looks like your correction here should put in a space. I see that using an actual space on a web link:
http://mpas-dev.github.io/MPAS-Model/latest%20coastal/
does work (i.e. replace %20 above with space on your browser)

@mark-petersen
Copy link
Contributor

mark-petersen commented Aug 17, 2020

@mgduda @matthewhoffman @akturner: FYI, for PRs to develop that only involve Travis CI and documentation, I will not ask for your approval, as we are still getting the kinks out.

sbrus89
sbrus89 approved these changes Aug 17, 2020
View reviewed changes
Copy link

@sbrus89 sbrus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar, this looks good to me!

@xylar
Copy link
Collaborator Author

xylar commented Aug 17, 2020

@mark-petersen, the space comes from this file:
https://github.com/xylar/MPAS-Model/blob/fix_docs_ci/travis_ci/get_docs_version.bash
It is intentional. However, I want to replace the space with an underscore in the URL because a %20 is an ugly thing to have in a URL even if it works. Mere when you're ready.

@mark-petersen mark-petersen merged commit c163462 into MPAS-Dev:develop Aug 17, 2020
mark-petersen added a commit that referenced this pull request Aug 17, 2020
@mark-petersen
Merge branch 'ocean/develop' into e3sm/develop
fe4d587 
* ocean/develop:
  Move load_compass_env.sh to the ocean dir #618
  Update ISOMIP+ docs, including tutorial for Ocean0 on LANL IC #653
  Fix path to docs in Travis CI #644
  New Mesh: WC14to60kmL60E3SMv2r03 #628
@mark-petersen mark-petersen mentioned this pull request Aug 17, 2020
Merged
jonbob added a commit to E3SM-Project/E3SM that referenced this pull request Aug 18, 2020
@jonbob
Merge branch 'mark-petersen/update_mpas_200817' into next (PR #3776)
72e0ed9 
Update MPAS-Source: COMPASS and Documentation files

This PRi brings in a new mpas-source submdoule with changes only to the ocean
core. It updates files unrelated to the E3SM forward model, including:
* Move load_compass_env.sh to the ocean dir  (MPAS-Dev/MPAS-Model#618);
* Update ISOMIP+ docs, including tutorial for Ocean0 on LANL IC
  (MPAS-Dev/MPAS-Model#653);
* Fix path to docs in Travis CI  (MPAS-Dev/MPAS-Model#644);
* atmosphere core init changes  (MPAS-Dev/MPAS-Model#637);
* New Mesh: WC14to60kmL60E3SMv2r03  (MPAS-Dev/MPAS-Model#628);
* Fix ISOMIP+ viz scripts  (MPAS-Dev/MPAS-Model#642);
* Add support for custom critical passages and land blockages
  (MPAS-Dev/MPAS-Model#586); and
* New Mesh: WC12to60kmL60E3SMv2r01  (MPAS-Dev/MPAS-Model#555)

[BFB]
jonbob added a commit to E3SM-Project/E3SM that referenced this pull request Aug 19, 2020
@jonbob
Merge branch 'mark-petersen/update_mpas_200817' (PR #3776)
b84ab6c 
Update MPAS-Source: COMPASS and Documentation files

This PR brings in a new mpas-source submdoule with changes only to the ocean
core. It updates files unrelated to the E3SM forward model, including:
* Move load_compass_env.sh to the ocean dir  (MPAS-Dev/MPAS-Model#618);
* Update ISOMIP+ docs, including tutorial for Ocean0 on LANL IC
  (MPAS-Dev/MPAS-Model#653);
* Fix path to docs in Travis CI  (MPAS-Dev/MPAS-Model#644);
* atmosphere core init changes  (MPAS-Dev/MPAS-Model#637);
* New Mesh: WC14to60kmL60E3SMv2r03  (MPAS-Dev/MPAS-Model#628);
* Fix ISOMIP+ viz scripts  (MPAS-Dev/MPAS-Model#642);
* Add support for custom critical passages and land blockages
  (MPAS-Dev/MPAS-Model#586); and
* New Mesh: WC12to60kmL60E3SMv2r01  (MPAS-Dev/MPAS-Model#555)

[BFB]
@xylar xylar deleted the fix_docs_path branch August 21, 2020 11:41
@matthewhoffman matthewhoffman added the CI only Changes only affect Azure Pipelines CI, not the code or documentation label Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mark-petersen mark-petersen mark-petersen approved these changes

+1 more reviewer

@sbrus89 sbrus89 sbrus89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mark-petersen mark-petersen

Labels

CI only Changes only affect Azure Pipelines CI, not the code or documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xylar @mark-petersen @sbrus89 @matthewhoffman