Bottom roughness (z_0) based drag term implementation #640
Closed
nairita87 wants to merge 1 commit intoMPAS-Dev:ocean/developfrom
Closed
Bottom roughness (z_0) based drag term implementation #640nairita87 wants to merge 1 commit intoMPAS-Dev:ocean/developfrom
nairita87 wants to merge 1 commit intoMPAS-Dev:ocean/developfrom
Conversation
|
@nairita87 Thanks! I will use this version. |
Collaborator
|
@nairita87, we usually title the pull request with a title that can be used in the merge commit as a meaningful title and the description of the PR as the remaining commit message, describing what the pull request is for. This helps us figure out later on when we're debugging changes to the code what each PR brought into the code. If you wouldn't mind, could you edit the title and description accordingly? You can make comments to other developers like you have above in subsequent comments, that's perfectly fine. |
Author
|
I am sorry @xylar I will do that |
nairita87
changed the title
sbrus89
force-pushed
the
ocean/coastal
branch
2 times, most recently
from
025c036 to
acea49c
Compare
mark-petersen
force-pushed
the
ocean_coastal_sub1
branch
from
c12f6b0 to
87d100f
Compare
… compilation bug)
nairita87
force-pushed
the
ocean_coastal_sub1
branch
from
87d100f to
1565779
Compare
Contributor
|
This is a repeat of #606. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculation of bottom drag coefficient "implicitCd" using NCOM'S formula :
cb(i,j) = max(cbmin, (vonk/(log(0.5*depth(i,j)/z0)))**2 )).
This bottom drag following the formulation is also used in HYCOM