Remove RediKappa from gm package #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanroekel
approved these changes
Jun 11, 2020
Contributor
vanroekel
left a comment
vanroekel
left a comment
There was a problem hiding this comment.
thanks @mark-petersen this fixes the issue in the nightly testing I've seen.
mark-petersen
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Jun 11, 2020
fixed bad array sizes in local ocean arrays MPAS-Dev/MPAS-Model#598 Remove RediKappa from gm package MPAS-Dev/MPAS-Model#602 Fixes bugs in tracer_advection_std MPAS-Dev/MPAS-Model#587
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Jun 15, 2020
…3634) Update mpas-source: three ocean bug fixes This PR brings in a new mpas-source submodule with changes only to the ocean core. It fixes three small bugs that do not impact any current E3SM test configurations: * fixes bad array sizes in local ocean arrays (MPAS-Dev/MPAS-Model#598) * removes RediKappa from gm package (MPAS-Dev/MPAS-Model#602) * fixes bugs in tracer_advection_std (MPAS-Dev/MPAS-Model#587) [BFB]
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Jun 16, 2020
Update mpas-source: three ocean bug fixes This PR brings in a new mpas-source submodule with changes only to the ocean core. It fixes three small bugs that do not impact any current E3SM test configurations: * fixes bad array sizes in local ocean arrays (MPAS-Dev/MPAS-Model#598) * removes RediKappa from gm package (MPAS-Dev/MPAS-Model#602) * fixes bugs in tracer_advection_std (MPAS-Dev/MPAS-Model#587) [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When RediKappa is included in the gm package, the intel 19 compiler in debug mode stops with an error when redi is off, because we try to pass it to the hmix subroutine. By removing it from the gm package, we use extra memory but code remains bit for bit. In a future PR we will put all redi and gm variables in the gm package, and make them all optional arguments.