fixed bad array sizes in local ocean arrays #598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
two ocean modules had local arrays that were
not properly sized to accommodate the practice
of using nCellsAll+1 (Edges, Vertices) as a
location to represent non-existent cells, edges, vertices
this commit extends the dimension by one for these arrays
mattdturner
approved these changes
Jun 5, 2020
Collaborator
mattdturner
left a comment
mattdturner
left a comment
There was a problem hiding this comment.
Approved by visual inspection
mark-petersen
approved these changes
Jun 8, 2020
Contributor
mark-petersen
left a comment
mark-petersen
left a comment
There was a problem hiding this comment.
Approved by inspection. I'm surprised this didn't cause problems on other compilers.
- previous commit changed array sizes in ocn mesh routine but
did not change following initialization loops.
- previous commit missed some similar loops in the update routine
Contributor
Author
|
Sorry guys, got a bit sloppy. When I fixed array sizes in the mesh module, I forgot to change subsequent initialization loop limits. Just pushed a fix (well, actually two commits because I missed a second set of loops in the update routine). Still b4b, and actually works in the branch where I triggered this bug. |
Contributor
|
Tested with gnu and intel, optimized and debug, is bfb with previous. |
mark-petersen
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Jun 11, 2020
fixed bad array sizes in local ocean arrays MPAS-Dev/MPAS-Model#598 Remove RediKappa from gm package MPAS-Dev/MPAS-Model#602 Fixes bugs in tracer_advection_std MPAS-Dev/MPAS-Model#587
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Jun 15, 2020
…3634) Update mpas-source: three ocean bug fixes This PR brings in a new mpas-source submodule with changes only to the ocean core. It fixes three small bugs that do not impact any current E3SM test configurations: * fixes bad array sizes in local ocean arrays (MPAS-Dev/MPAS-Model#598) * removes RediKappa from gm package (MPAS-Dev/MPAS-Model#602) * fixes bugs in tracer_advection_std (MPAS-Dev/MPAS-Model#587) [BFB]
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Jun 16, 2020
Update mpas-source: three ocean bug fixes This PR brings in a new mpas-source submodule with changes only to the ocean core. It fixes three small bugs that do not impact any current E3SM test configurations: * fixes bad array sizes in local ocean arrays (MPAS-Dev/MPAS-Model#598) * removes RediKappa from gm package (MPAS-Dev/MPAS-Model#602) * fixes bugs in tracer_advection_std (MPAS-Dev/MPAS-Model#587) [BFB]
mark-petersen
added a commit
to mark-petersen/MPAS-Model
that referenced
this pull request
Jan 11, 2021
fixed bad array sizes in local ocean arrays MPAS-Dev#598 Two ocean modules had local arrays that were not properly sized to accommodate the practice of using nCellsAll+1 (Edges, Vertices) as a location to represent non-existent cells, edges, vertices. This would result in out-of-bounds references. This fix just extends the dimension by one for the arrays that will potentially be referenced in this way. Fixes MPAS-Dev#597 [b4b] in QU240 test on Summit - meaning out of bounds refs so far had fortunately no impact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two ocean modules had local arrays that were not properly sized to accommodate the practice of using nCellsAll+1 (Edges, Vertices) as a location to represent non-existent cells, edges, vertices. This would result in out-of-bounds references. This fix just extends the dimension by one for the arrays that will potentially be referenced in this way.
Fixes #597
[b4b] in QU240 test on Summit - meaning out of bounds refs so far had fortunately no impact