Fixes surface waves case #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug introduced in MPAS-Dev#456 where vertical mesh incorrectly assumes on-land and below-water slopes between left and right boundary
Contributor
Author
Testing
|
Contributor
Author
|
cc @caozd999 for testing with your cases |
I git-rebased this branch and tested my marsh_case/250m with no problem. drying_slope/marsh_case/250m/Tidal boundary water level |
Contributor
Author
|
@mark-petersen, this should be an easy PR to review since it only handles a coastal init mode case. |
Contributor
Author
|
@mark-petersen, is it possible to get this merged this week? |
|
@mark-petersen, I'm going to go ahead and merge this since it only affects init mode code for this specific case. |
Contributor
|
Great. Thanks for taking care of it @sbrus89 |
|
No problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug fixes issue introduced in #456 where the vertical mesh for the surface waves case is incorrectly specified.