Skip to content

Fixes bugs in tracer_advection_std#587

Merged
mark-petersen merged 1 commit intoMPAS-Dev:ocean/developfrom
vanroekel:ocean/fixNonMonotoneAdvection
Jun 11, 2020
Merged

Fixes bugs in tracer_advection_std#587
mark-petersen merged 1 commit intoMPAS-Dev:ocean/developfrom
vanroekel:ocean/fixNonMonotoneAdvection

Conversation

@vanroekel
Copy link
Contributor

@vanroekel vanroekel commented Jun 3, 2020

Currently there are calls in tracer_advection_std to scratch pool arrays
that have been removed from registry. This commit makes std advection
functional again.

@vanroekel
Fixes bugs in tracer_advection_std
52b03c4 
Currently there are calls in tracer_advection_std to scratch pool arrays
that have been removed from registry.  This commit makes std advection
functional again.
@vanroekel vanroekel requested a review from mark-petersen June 3, 2020 16:49
@vanroekel
Copy link
Contributor Author

vanroekel commented Jun 3, 2020

@mark-petersen this PR is needed to get tracer_advection_std functional again. Right now it dies on the first timestep due to a memory access bug. This should fix this. I wanted to post this as it may be useful or further advection testing.

@vanroekel
Copy link
Contributor Author

vanroekel commented Jun 3, 2020

also tagging @jamilgafur as this might be good to test in your horizontal advection test. Merge this in and set config_monotonic = .false.

@mark-petersen
Copy link
Contributor

mark-petersen commented Jun 4, 2020

@vanroekel thanks for posting. @mattdturner removed all the scratch var_struct variables in #457 and replaced them with local old-fashioned allocatable arrays. That PR is on schedule to merge next week. I think that will take care of this problem, but we will make sure to test the tracer_advection_std routine, and leave this PR open until that is done.

@mark-petersen mark-petersen self-assigned this Jun 4, 2020
mark-petersen
mark-petersen approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and merge this so it works now. This section will be revised when we merge #457.

@mark-petersen mark-petersen merged commit 3fa689e into MPAS-Dev:ocean/develop Jun 11, 2020
mark-petersen added a commit to E3SM-Project/E3SM that referenced this pull request Jun 11, 2020
@mark-petersen
Update mpas-source: three bug fixes
a24770c 
fixed bad array sizes in local ocean arrays
  MPAS-Dev/MPAS-Model#598
Remove RediKappa from gm package
  MPAS-Dev/MPAS-Model#602
Fixes bugs in tracer_advection_std
  MPAS-Dev/MPAS-Model#587
@mark-petersen mark-petersen mentioned this pull request Jun 11, 2020
Merged
jonbob added a commit to E3SM-Project/E3SM that referenced this pull request Jun 15, 2020
@jonbob
Merge branch 'mark-petersen/ocean/update_mpas_200611' into next (PR #…
e2e9faf 
…3634)

Update mpas-source: three ocean bug fixes

This PR brings in a new mpas-source submodule with changes only to the
ocean core. It fixes three small bugs that do not impact any current
E3SM test configurations:
* fixes bad array sizes in local ocean arrays (MPAS-Dev/MPAS-Model#598)
* removes RediKappa from gm package (MPAS-Dev/MPAS-Model#602)
* fixes bugs in tracer_advection_std (MPAS-Dev/MPAS-Model#587)

[BFB]
jonbob added a commit to E3SM-Project/E3SM that referenced this pull request Jun 16, 2020
@jonbob
Merge branch 'mark-petersen/ocean/update_mpas_200611' (PR #3634)
cff12d2 
Update mpas-source: three ocean bug fixes

This PR brings in a new mpas-source submodule with changes only to the
ocean core. It fixes three small bugs that do not impact any current
E3SM test configurations:
* fixes bad array sizes in local ocean arrays (MPAS-Dev/MPAS-Model#598)
* removes RediKappa from gm package (MPAS-Dev/MPAS-Model#602)
* fixes bugs in tracer_advection_std (MPAS-Dev/MPAS-Model#587)

[BFB]
mark-petersen added a commit to mark-petersen/MPAS-Model that referenced this pull request Jan 11, 2021
@mark-petersen
Merge PR MPAS-Dev#587 'vanroekel/ocean/fixNonMonotoneAdvection' into …
9c61276 
…ocean/develop

Fixes bugs in tracer_advection_std MPAS-Dev#587

Currently there are calls in tracer_advection_std to scratch pool arrays
that have been removed from registry. This commit makes std advection
functional again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mark-petersen mark-petersen mark-petersen approved these changes

Assignees

@mark-petersen mark-petersen

Labels

bug Ocean

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vanroekel @mark-petersen @matthewhoffman