Ocean/remove unused modules#569
Conversation
|
passes nightly regression suite. |
|
@vanroekel @pwolfram or @xylar |
pwolfram
left a comment
pwolfram
left a comment
There was a problem hiding this comment.
Only substantive comment I have here-- why removal of the tensor operations? Only have a few minor comments / questions sprinkled throughout.
testing_and_setup/compass/ocean/overflow/1km/rpe_test/config_rpe_test_6_nu_1000.xml
Show resolved
Hide resolved
testing_and_setup/compass/ocean/surface_waves/thickness_source/1km/config_forward.xml
Show resolved
Hide resolved
|
@mark-petersen, did a quick visual inspection review with comments / questions above. |
This was discussed in these comments: |
xylar
left a comment
xylar
left a comment
There was a problem hiding this comment.
Wow, @mark-petersen, this was quite an endeavor! Thanks for taking care of it. It will be very nice to have the code slimmed down this way.
I looked through the changes to test cases in particular and I think you've done a great job at making sure the new settings with CVMix only are the same as the old ones (where that's possible).
|
@mark-petersen, cleaned up comments above-- only real issue left is potential concern over mixing used in SOMA, especially since @lizcarlson needs it for her work. |
vanroekel
left a comment
vanroekel
left a comment
There was a problem hiding this comment.
@mark-petersen this looks great. Nice work getting all the settings in order. Just a few questions about a few test cases, but this looks good.
testing_and_setup/compass/ocean/internal_waves/5km/internal_waves_5km_template.xml
Show resolved
Hide resolved
|
@vanroekel is correct, my main simulations are complete and I run them from my own branch anyway, so any changes made here will not affect the results. Thanks for checking @pwolfram!
(@pwolfram removed email reply info)
|
|
@lizcarlson, so very happy too hear-- thanks for confirming so we can move forward! |
|
@mark-petersen, as far as I can tell @xylar, @vanroekel, @lizcarlson and myself worked through all issues and you can merge now.. |
|
PS-- congrats on a -2k or so line PR, code will be better for it! |
Update mpas-source: analysis member update, remove unused modules This PR brings in a new mpas-source submodule with changes only to the ocean, including several updates to analysis members and removing modules that are not used in E3SM simulations: * Adds normalVelocity arrays to eddy products (MPAS-Dev/MPAS-Model#544) * Adds Ocean Heat Content AM (MPAS-Dev/MPAS-Model#455) * Ocean/remove unused modules (MPAS-Dev/MPAS-Model#569) It includes corresponding changes to E3SM namelists and streams files for MPAS-Ocean. COMPASS changes associated with these PRs are also included. [NML] [BFB]
…3613) Update mpas-source: analysis member update, remove unused modules Re-merged after fixes for debug failures, excess output This PR brings in a new mpas-source submodule with changes only to the ocean, including several updates to analysis members and removing modules that are not used in E3SM simulations: * Adds normalVelocity arrays to eddy products (MPAS-Dev/MPAS-Model#544) * Adds Ocean Heat Content AM (MPAS-Dev/MPAS-Model#455) * Ocean/remove unused modules (MPAS-Dev/MPAS-Model#569) It includes corresponding changes to E3SM namelists and streams files for MPAS-Ocean. COMPASS changes associated with these PRs are also included. [NML] [BFB]
Update mpas-source: analysis member update, remove unused modules This PR brings in a new mpas-source submodule with changes only to the ocean, including several updates to analysis members and removing modules that are not used in E3SM simulations: * Adds normalVelocity arrays to eddy products (MPAS-Dev/MPAS-Model#544) * Adds Ocean Heat Content AM (MPAS-Dev/MPAS-Model#455) * Ocean/remove unused modules (MPAS-Dev/MPAS-Model#569) It includes corresponding changes to E3SM namelists and streams files for MPAS-Ocean. COMPASS changes associated with these PRs are also included. [NML] [BFB]
Ocean/remove unused modules MPAS-Dev#569 Removes these modules: vmix vmix_const vmix_rich vmix_tanh hmix_del2_tensor hmix_del4_tensor The vmix modules are replaced by cvmix. Redundant code is poor practice and leads to errors. The hmix tensor routines were experimental. They caused noisy fields and were never used in the end. All the COMPASS tests that used vmix_const were changed over to cvmix with constant background viscosity. The others were not used by COMPASS tests. Fixes MPAS-Dev#557
Ocean/remove unused modules MPAS-Dev#569 Removes these modules: vmix vmix_const vmix_rich vmix_tanh hmix_del2_tensor hmix_del4_tensor The vmix modules are replaced by cvmix. Redundant code is poor practice and leads to errors. The hmix tensor routines were experimental. They caused noisy fields and were never used in the end. All the COMPASS tests that used vmix_const were changed over to cvmix with constant background viscosity. The others were not used by COMPASS tests. Fixes MPAS-Dev#557
6 participants
Removes these modules:
The vmix modules are replaced by cvmix. Redundant code is poor practice and leads to errors. The hmix tensor routines were experimental. They caused noisy fields and were never used in the end.
All the COMPASS tests that used
vmix_constwere changed over to cvmix with constant background viscosity. The others were not used by COMPASS tests.Fixes #557