Remove scratch allocates and config. Part 2: Init mode #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdturner
approved these changes
May 11, 2020
Collaborator
mattdturner
left a comment
mattdturner
left a comment
There was a problem hiding this comment.
Approved via visual inspection
mattdturner
force-pushed
the
ocean/remove_scratch_allocate_2_init_mode
branch
from
2b5d1f9 to
b1056a4
Compare
Collaborator
|
Just rebased to the current |
Contributor
Author
|
On grizzly, tested nightly regression suite with gnu, intel17, intel19 with PIO2. Tested both debug and optimized. Passes all tests except there is a problem with the |
mark-petersen
force-pushed
the
ocean/remove_scratch_allocate_2_init_mode
branch
from
b1056a4 to
1569ce9
Compare
This was referenced Jul 15, 2020
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Jul 22, 2020
…is' into next (PR #3717) Update mpas-source: remove scratch allocates, analysis and init This PR brings in a new mpas-source submodule with changes only to the ocean core. Those changes represent two MPAS-Ocean PRs with similar improvements but to two different parts of the model: * Remove scratch allocates and config. Part 1: analysis members (MPAS-Dev/MPAS-Model#539) * Remove scratch allocates and config. Part 2: Init mode (MPAS-Dev/MPAS-Model#553) These are each part of MPAS-Dev/MPAS-Model#457, which replaces scratch allocates throughout the model. We felt it was safer to convert the model in smaller pieces. [BFB]
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Jul 23, 2020
…is' (PR #3717) Update mpas-source: remove scratch allocates, analysis and init This PR brings in a new mpas-source submodule with changes only to the ocean core. Those changes represent two MPAS-Ocean PRs with similar improvements but to two different parts of the model: * Remove scratch allocates and config. Part 1: analysis members (MPAS-Dev/MPAS-Model#539) * Remove scratch allocates and config. Part 2: Init mode (MPAS-Dev/MPAS-Model#553) These are each part of MPAS-Dev/MPAS-Model#457, which replaces scratch allocates throughout the model. We felt it was safer to convert the model in smaller pieces. [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of #457.