Remove scratch allocates and config. Part 1: analysis members#539
Conversation
|
Passes nightly regression suite on grizzly with gnu and intel, optimized and debug. @mattdturner, the first commit 2fda23a is exactly your changes. There were a few corrections for the Lagrangian particles, which I put in a second commit. You can review by inspection, since I tested. This will be the first performance PR to be merged, but E3SM repo is closed right now, and we wait for that. |
mattdturner
left a comment
mattdturner
left a comment
There was a problem hiding this comment.
Approved by visual inspection and @mark-petersen testing.
There was a problem hiding this comment.
The allocatable statements might actually need to be module-level instead of subroutine-level. This is a non-issue once #513 is merged, but having the global !$omp parallel implementation could cause the subroutine-level allocatable definitions to result in segfaults if running on multiple threads.
mark-petersen
force-pushed
the
ocean/remove_scratch_allocate_1_analysis_members
branch
from
dc30637 to
536249a
Compare
|
rebased, tested. |
mattdturner
force-pushed
the
ocean/remove_scratch_allocate_1_analysis_members
branch
from
ee9fd56 to
a60f268
Compare
|
I just rebased this PR. It passed all tests in the nightly regression suite w/ Intel on Cori, except the Periodic Planar tests (state validation failed). The periodic planar tests also failed for |
|
On grizzly, passes nightly regression suite with gnu, intel17, intel19 with PIO2. Tested both debug and optimized. BFB with previous on all tests. |
mark-petersen
force-pushed
the
ocean/remove_scratch_allocate_1_analysis_members
branch
from
d3ecb61 to
13342d3
Compare
…is' into next (PR #3717) Update mpas-source: remove scratch allocates, analysis and init This PR brings in a new mpas-source submodule with changes only to the ocean core. Those changes represent two MPAS-Ocean PRs with similar improvements but to two different parts of the model: * Remove scratch allocates and config. Part 1: analysis members (MPAS-Dev/MPAS-Model#539) * Remove scratch allocates and config. Part 2: Init mode (MPAS-Dev/MPAS-Model#553) These are each part of MPAS-Dev/MPAS-Model#457, which replaces scratch allocates throughout the model. We felt it was safer to convert the model in smaller pieces. [BFB]
…is' (PR #3717) Update mpas-source: remove scratch allocates, analysis and init This PR brings in a new mpas-source submodule with changes only to the ocean core. Those changes represent two MPAS-Ocean PRs with similar improvements but to two different parts of the model: * Remove scratch allocates and config. Part 1: analysis members (MPAS-Dev/MPAS-Model#539) * Remove scratch allocates and config. Part 2: Init mode (MPAS-Dev/MPAS-Model#553) These are each part of MPAS-Dev/MPAS-Model#457, which replaces scratch allocates throughout the model. We felt it was safer to convert the model in smaller pieces. [BFB]
…rs' into ocean/develop Remove scratch allocates and config. Part 1: analysis members MPAS-Dev#539 Part 1 of MPAS-Dev#457.
mark-petersen
deleted the
ocean/remove_scratch_allocate_1_analysis_members
branch
3 participants
Part 1 of #457.