Optimizations for tracer horizontal mixing#538
Closed
mattdturner wants to merge 3 commits intoMPAS-Dev:ocean/developfrom
Closed
Optimizations for tracer horizontal mixing#538mattdturner wants to merge 3 commits intoMPAS-Dev:ocean/developfrom
mattdturner wants to merge 3 commits intoMPAS-Dev:ocean/developfrom
Conversation
Collaborator
Author
|
This was tested using a QU240 test case, and a EC60to30 test case (both generated via Compass). The results are bit-for-bit with Intel compiler on Cori. As a result of the optimizations in this PR, there is a reduction of the time spent in tracer hmix by approx. 5%. Unfortunately, all of this runtime reduction came from the |
philipwjones
approved these changes
Apr 29, 2020
Contributor
philipwjones
left a comment
philipwjones
left a comment
There was a problem hiding this comment.
This was b4b on Summit with PGI as well. Visual inspection looked fine
mattdturner
force-pushed
the
ocean/tracer_hmix_ocnMesh
branch
from
4d60a8d to
61c2371
Compare
Collaborator
Author
|
Rebased to current |
mattdturner
force-pushed
the
ocean/tracer_hmix_ocnMesh
branch
from
61c2371 to
15c1548
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimizations to tracer horizontal mixing that include
ocn_meshmodule (relies on PR New ocean mesh structure with GPU replication #496 being merged)This PR requires the following PRs be merged first:
Some of the changes in those PRs were either git cherry-pick'ed or manually added. As a result, once those PRs are merged there might need to be some commits squashed or changes reverted in this PR.