Added build support for Summit at OLCF and OpenACC for GPU acceleration#536
Merged
mark-petersen merged 1 commit intoMPAS-Dev:developfrom May 27, 2020
philipwjones:framework/summitmake
Merged
Added build support for Summit at OLCF and OpenACC for GPU acceleration#536mark-petersen merged 1 commit intoMPAS-Dev:developfrom philipwjones:framework/summitmake
mark-petersen merged 1 commit intoMPAS-Dev:developfrom
philipwjones:framework/summitmake
Conversation
mark-petersen
approved these changes
May 19, 2020
Contributor
mark-petersen
left a comment
mark-petersen
left a comment
There was a problem hiding this comment.
Approved based on visual inspection.
Contributor
|
@mgduda @mattdturner @akturner Could you please comment or approve this week? |
mattdturner
approved these changes
May 19, 2020
Collaborator
mattdturner
left a comment
mattdturner
left a comment
There was a problem hiding this comment.
Approved by visual inspection.
matthewhoffman
approved these changes
May 19, 2020
Contributor
|
@philipwjones are there accompanying changes to the cmake build system required here? Are you altering this for stand-alone only right now, or do you want to run within E3SM for pgi-summit and OpenACC? |
Contributor
Author
|
Yes. The target and compiler flags are set elsewhere for the Cmake build, so I think the only change in our repo is to set the MPAS_OPENACC ifdef (like for OpenMP) but I didn't know that the equivalent of build_threaded is in the E3SM build. So maybe go ahead with a standalone mod only unless @jonbob or @jgfouca can let us know what the correct OpenACC mods are in e3sm (if there are any?) |
mgduda
approved these changes
May 26, 2020
Contributor
mgduda
left a comment
mgduda
left a comment
There was a problem hiding this comment.
Sorry for the delay. This looks good to me, and it's compatible with what we've been working on for MPAS-Atmosphere.
This change adds a pgi-summit entry and adds an OPENACC option similar to the OpenMP option to enable GPU acceleration for OpenACC code.
Contributor
|
Changed base to develop, since this is top level makefile. @philipwjones you will see this in e3sm when we merge develop into e3sm/develop, in the next week or two. |
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Jul 27, 2020
#3737) Update MPAS framework This PR brings in a new mpas-source submodule with updates to the mpas framework itself, plus changes to the cores supporting the framework update. Some changes are made to the atmosphere core, even though it is not used by E3SM, in order to maintain consistency with the framework. This update includes the following individual branches and PRs, many of which are additions to the makefiles for summit, or optional libraries: * az/azamat/mpas-cmake/mpas-tool-dir (MPAS-Dev/MPAS-Model#629) * init_atmosphere/kd_tree_ties (MPAS-Dev/MPAS-Model#630) * mark-petersen/framework/add_FillValue (MPAS-Dev/MPAS-Model#616) * mark-petersen/framework/add_lapack_option (MPAS-Dev/MPAS-Model#613) * amametjanov/framework/nullify-field-pointers (MPAS-Dev/MPAS-Model#578) * framework/makefile_e3sm (MPAS-Dev/MPAS-Model#603) * xylar/framework/make_shell_bash (MPAS-Dev/MPAS-Model#594) * registry/missing_value (MPAS-Dev/MPAS-Model#562) * pwolfram/updates_make_intel_stack (MPAS-Dev/MPAS-Model#592) * azamat/framework/pgi-cpr-omp-workaround (MPAS-Dev/MPAS-Model#449) * az/framework/e3sm-cmake-qnosmp-typo (MPAS-Dev/MPAS-Model#579) * xylar/compass/add_prerequisite_tag * atmosphere/fix_timekeeping_imports (MPAS-Dev/MPAS-Model#582) * xylar/fix_docs_ci (MPAS-Dev/MPAS-Model#575) * xylar/add_compass_docs (MPAS-Dev/MPAS-Model#472) * philipwjones/framework/summitmake (MPAS-Dev/MPAS-Model#536) * atmosphere/atm_core_cleanup (MPAS-Dev/MPAS-Model#548) * init_atmosphere/parse_geoindex (MPAS-Dev/MPAS-Model#459) * xylar/compass/add_copy_file (MPAS-Dev/MPAS-Model#467) * init_atmosphere/kd_tree (MPAS-Dev/MPAS-Model#438) * init_atmosphere/mpas_stack (MPAS-Dev/MPAS-Model#426) * operators/add_mpas_in_cell (MPAS-Dev/MPAS-Model#400) Fixes #3396 Fixes #3236 [BFB]
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Jul 29, 2020
Update MPAS framework This PR brings in a new mpas-source submodule with updates to the mpas framework itself, plus changes to the cores supporting the framework update. Some changes are made to the atmosphere core, even though it is not used by E3SM, in order to maintain consistency with the framework. This update includes the following individual branches and PRs, many of which are additions to the makefiles for summit, or optional libraries: * az/azamat/mpas-cmake/mpas-tool-dir (MPAS-Dev/MPAS-Model#629) * init_atmosphere/kd_tree_ties (MPAS-Dev/MPAS-Model#630) * mark-petersen/framework/add_FillValue (MPAS-Dev/MPAS-Model#616) * mark-petersen/framework/add_lapack_option (MPAS-Dev/MPAS-Model#613) * amametjanov/framework/nullify-field-pointers (MPAS-Dev/MPAS-Model#578) * framework/makefile_e3sm (MPAS-Dev/MPAS-Model#603) * xylar/framework/make_shell_bash (MPAS-Dev/MPAS-Model#594) * registry/missing_value (MPAS-Dev/MPAS-Model#562) * pwolfram/updates_make_intel_stack (MPAS-Dev/MPAS-Model#592) * azamat/framework/pgi-cpr-omp-workaround (MPAS-Dev/MPAS-Model#449) * az/framework/e3sm-cmake-qnosmp-typo (MPAS-Dev/MPAS-Model#579) * xylar/compass/add_prerequisite_tag * atmosphere/fix_timekeeping_imports (MPAS-Dev/MPAS-Model#582) * xylar/fix_docs_ci (MPAS-Dev/MPAS-Model#575) * xylar/add_compass_docs (MPAS-Dev/MPAS-Model#472) * philipwjones/framework/summitmake (MPAS-Dev/MPAS-Model#536) * atmosphere/atm_core_cleanup (MPAS-Dev/MPAS-Model#548) * init_atmosphere/parse_geoindex (MPAS-Dev/MPAS-Model#459) * xylar/compass/add_copy_file (MPAS-Dev/MPAS-Model#467) * init_atmosphere/kd_tree (MPAS-Dev/MPAS-Model#438) * init_atmosphere/mpas_stack (MPAS-Dev/MPAS-Model#426) * operators/add_mpas_in_cell (MPAS-Dev/MPAS-Model#400) Fixes #3396 Fixes #3236 [BFB]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a pgi-summit entry to the top level Makefile and adds an OPENACC option
similar to the OpenMP option to enable GPU acceleration for OpenACC decorated code.