Buffer mask for signed distance by dlat #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make sure the mask includes the various boundaries
Collaborator
Author
|
@mark-petersen, I noticed that the signed distance function had the wrong function for the row containing the North Pole for any shape that extends that far north. This seems to be because the |
mark-petersen
approved these changes
Apr 20, 2020
Contributor
mark-petersen
left a comment
mark-petersen
left a comment
There was a problem hiding this comment.
Looks good. Approved based on @xylar's testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make sure the mask includes the various boundaries.