Skip to content

Convert CUSP to signed distance#523

Merged
mark-petersen merged 1 commit intoMPAS-Dev:ocean/developfrom
mark-petersen:cusp_signed_distance
Apr 29, 2020
Merged

Convert CUSP to signed distance#523
mark-petersen merged 1 commit intoMPAS-Dev:ocean/developfrom
mark-petersen:cusp_signed_distance

Conversation

@mark-petersen
Copy link
Contributor

@mark-petersen mark-petersen commented Apr 18, 2020

Re-design of CUSP mesh using a number of overlaid regions. Each region begins with a signed distance from a geojson region file. A mask is computed using a tanh function on the signed distance.

@mark-petersen mark-petersen added Ocean COMPASS For discussion PRs and Issues that are open for discussion and feedback labels Apr 18, 2020
@mark-petersen
Copy link
Contributor Author

@xylar, it would be great to hear your thoughts on this. The details are preliminary, but the process is in place. It automatically generates this plot, which shows how there are five masks, and each one adds to the high resolution region. There are very few points in each geojson file (also added to this PR) so the regions are easy to alter.
mesh_construction
cellWidthGlobal

@xylar xylar mentioned this pull request Apr 18, 2020
@xylar
Copy link
Collaborator

xylar commented Apr 19, 2020

Please rebase onto #526 and cherry-pick #527 (and make any changes to those PRs if you're not happy with them). Otherwise, we're competing with one another.

@mark-petersen mark-petersen marked this pull request as draft April 20, 2020 16:21
@mark-petersen mark-petersen self-assigned this Apr 22, 2020
@mark-petersen mark-petersen changed the title CUSP based on signed distance CUSP12to60E2r01: Coastal US Plus mesh, based on signed distance Apr 22, 2020
@mark-petersen
Copy link
Contributor Author

Rebased on ocean/develop. This takes care of @xylar's requests above.

@mark-petersen
Copy link
Contributor Author

Rebased and updated.
cellWidthGlobal
mesh_construction

@mark-petersen mark-petersen marked this pull request as ready for review April 29, 2020 13:52
@mark-petersen mark-petersen removed For discussion PRs and Issues that are open for discussion and feedback mesh labels Apr 29, 2020
@mark-petersen mark-petersen changed the title CUSP12to60E2r01: Coastal US Plus mesh, based on signed distance Convert CUSP to signed distance Apr 29, 2020
@mark-petersen
Copy link
Contributor Author

@xylar, I would like to have two PRs for the CUSP mesh. This one is just implementing the signed distance function and the plots, and it is complete. Then I will open a new one with the mesh label, that can be open for discussion for a while. That way we separate the first implementation from the group discussions.

You already reviewed it once, but I'm happy to hear further comments. Otherwise, please approve and I'll merge it in.

Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as a starting point for further discussion.

@mark-petersen mark-petersen merged commit ae6e198 into MPAS-Dev:ocean/develop Apr 29, 2020
@mark-petersen mark-petersen deleted the cusp_signed_distance branch May 11, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants