Skip to content

Add hurricane Sandy test case with synthetic winds #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pwolfram merged 6 commits into from
Apr 2, 2020
Merged

Add hurricane Sandy test case with synthetic winds #491

pwolfram merged 6 commits into from
Apr 2, 2020

Conversation

@sbrus89
Copy link

@sbrus89 sbrus89 commented Mar 25, 2020

  • Includes the hurricane_wind_pressure code from Donatella Pasqualini that interpolates a parametric wind field onto the MPAS-O mesh

  • New test case (ocean/hurricane/USDEQU120at30cr10rr2/synthetic_sandy) includes a tidal spin-up period before the storm winds begin. This is needed because the storm winds only cover a 3 day period prior to landfall (no enough time to spin-up tides accurately)

  • Also, adds the ability to delay the ramp on the atmospheric forcing. In this case this is used to delay the wind/pressure forcing ramp until after the tidal spin-up.

@sbrus89 sbrus89 requested a review from pwolfram March 25, 2020 18:53
@sbrus89
Copy link
Author

sbrus89 commented Mar 26, 2020

From the 9 day spinup:

8534720
8536110
8537121
8557380
8570283

@sbrus89
Copy link
Author

sbrus89 commented Mar 26, 2020

From the forward run with winds:

8534720
8536110
8537121
8557380
8570283

@sbrus89
Copy link
Author

sbrus89 commented Mar 26, 2020

From the forward run:

winds_00
winds_01
winds_02
winds_03

@sbrus89
Copy link
Author

sbrus89 commented Mar 26, 2020

Note, that this storm produces a much higher surge than the reanalysis winds:

8519483

Also, the run fails with an instability about a day early...

@sbrus89
Copy link
Author

sbrus89 commented Mar 26, 2020 •
edited
Loading

From the forward run:

ssh_00
ssh_01
ssh_02
ssh_03

@sbrus89
Copy link
Author

sbrus89 commented Mar 26, 2020

@pwolfram, I think this is ready for you to take a look at.

@sbrus89
Copy link
Author

sbrus89 commented Mar 26, 2020

There are some hardcoded dates in spinup_time_varying_forcing.py and hurricane_wind_pressure/winds_io/output_data.py that should be changed to input arguments.

@sbrus89 sbrus89 force-pushed the synthetic_sandy branch 2 times, most recently from eab963c to 7741786 Compare March 26, 2020 20:09
@sbrus89
Copy link
Author

sbrus89 commented Mar 26, 2020

The issues with hardcoded dates is now fixed

@sbrus89
Copy link
Author

sbrus89 commented Mar 26, 2020

@pwolfram, if you have trouble with the init step, let me know. For whatever reason (probably related to a .gitignore file), I had issues adding all of Donatella's code. I think it's all there now, but if something breaks that's a likely reason.

@sbrus89
Copy link
Author

sbrus89 commented Mar 30, 2020 •
edited
Loading

Instability is likely to to drying at the upper portion of Chesapeake Bay.

Region of instability from maps_ocean_block_stats:

instability

@pwolfram
Copy link
Contributor

pwolfram commented Apr 1, 2020

@sbrus89, is this ready for my review? This doesn't depend on other things like #498 or #366 directly so I think we should merge to move forward and have very specific integration PRs as needed.

@sbrus89
Copy link
Author

sbrus89 commented Apr 1, 2020

@pwolfram , yes, I think it's ready for you to review. Let me know if you have suggestions or fixes.

@pwolfram
Copy link
Contributor

pwolfram commented Apr 1, 2020

Thanks @sbrus89, will check it out.

@pwolfram
Copy link
Contributor

pwolfram commented Apr 1, 2020

Notes: Using IC's test_compass until rasterio is merged into the COMPAS conda environment in MPAS-Dev/MPAS-Tools#303.

Add synthetic wind and tidal spin-up capabilities
cc38359 
 - Includes the hurricane_wind_pressure code from Donatella Pasqualini
   that interpolates a parametric wind field onto the MPAS-O mesh

 - New test case (ocean/hurricane/USDEQU120at30cr10rr2/synthetic_sandy)
   includes a tidal spin-up period before the storm winds begin.

   This is needed because the storm winds only cover a 3 day period prior to
   landfall (not enough time to spin-up tides accurately)

 - Also, adds the ability to delay the ramp for the atmospheric forcing.
   In this case this is used to delay the wind/pressure forcing ramp until
   after the tidal spin-up.
@mark-petersen mark-petersen self-requested a review April 1, 2020 20:24
mark-petersen
mark-petersen approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this passes your tests, it's all fine with me. Only small changes to the forward model. The rest is in COMPASS.

@pwolfram
Copy link
Contributor

pwolfram commented Apr 2, 2020

Thanks @mark-petersen, plan to merge after completing testing, likely tomorrow.

pwolfram
pwolfram suggested changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@pwolfram pwolfram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minimal changes are flagged. Also, testing code use and will report back to make sure results are comparable to @sbrus89.

@pwolfram
Copy link
Contributor

pwolfram commented Apr 2, 2020

Note that this will have to be tuned / integrated with other parts of code so this is an incomplete solution for arbitrary hurricanes for now. I confirm the results above and consider this acceptable following the minor changes flagged above.

Testing

Spinup:

image

Forward:

image

pwolfram
pwolfram approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@pwolfram pwolfram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved new edits by inspection.

@pwolfram pwolfram merged commit e528e28 into MPAS-Dev:ocean/coastal Apr 2, 2020
@pwolfram
Copy link
Contributor

pwolfram commented Apr 2, 2020

Thanks @sbrus89!

@pwolfram pwolfram deleted the synthetic_sandy branch April 2, 2020 21:51
@pwolfram
Copy link
Contributor

pwolfram commented Apr 16, 2020 •
edited
Loading

Application of this code to wetting and drying staged in #520

@pwolfram pwolfram mentioned this pull request Jul 3, 2020
Merged
@pwolfram
Copy link
Contributor

pwolfram commented Jul 3, 2020

Needs #626 to resole #625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mark-petersen mark-petersen mark-petersen approved these changes

+1 more reviewer

@pwolfram pwolfram pwolfram approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pwolfram pwolfram

Labels

coastal feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sbrus89 @pwolfram @mark-petersen @matthewhoffman