Skip to content

Adds drying slope wetting and drying above land #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pwolfram merged 1 commit into from
Mar 2, 2020
Merged

Adds drying slope wetting and drying above land #456

pwolfram merged 1 commit into from
Mar 2, 2020

Conversation

@pwolfram
Copy link
Contributor

@pwolfram pwolfram commented Feb 26, 2020

Refractors the zstar test case to allow for above-land wetting/drying in a new test case.

@pwolfram
Adds drying slope wetting and drying above land
8a904e1 
Refractors the zstar test case to allow for above-land wetting/drying.
@pwolfram
Copy link
Contributor Author

pwolfram commented Feb 26, 2020

Testing of compass/ocean/drying_slope/zstar_above_land/1km:

image

This is a simple hello-world for testing of bottomDepth < 0:

cd forward
ncdump -v bottomDepth output.nc | tail -n 40
		:config_tidal_boundary_plug_width_frac = 0.1 ;
		:config_tidal_forcing_left_Cd_or_n = 0.001 ;
		:config_tidal_forcing_right_Cd_or_n = 0.001 ;
		:file_id = "movf4xncje" ;
data:

 bottomDepth = -8.6, -8.6, -8.6, -8.6, -8.6, -8.6, -7.8, -7.8, -7.8, -7.8, 
    -7.8, -7.8, -7.2, -7.2, -7.2, -7.2, -7.2, -7.2, -6.4, -6.4, -6.4, -6.4, 
    -6.4, -6.4, -5.8, -5.8, -5.8, -5.8, -5.8, -5.8, -5, -5, -5, -5, -5, -5, 
    -4.4, -4.4, -4.4, -4.4, -4.4, -4.4, -3.6, -3.6, -3.6, -3.6, -3.6, -3.6, 
    -3, -3, -3, -3, -3, -3, -2.2, -2.2, -2.2, -2.2, -2.2, -2.2, -1.6, -1.6, 
    -1.6, -1.6, -1.6, -1.6, -0.799999999999995, -0.799999999999995, 
    -0.799999999999995, -0.799999999999995, -0.799999999999995, 
    -0.799999999999995, -0.199999999999994, -0.199999999999994, 
    -0.199999999999994, -0.199999999999994, -0.199999999999994, 
    -0.199999999999994, 0.400000000000006, 0.400000000000006, 
    0.400000000000006, 0.400000000000006, 0.400000000000006, 
    0.400000000000006, 1.20000000000001, 1.20000000000001, 1.20000000000001, 
    1.20000000000001, 1.20000000000001, 1.20000000000001, 1.80000000000001, 
    1.80000000000001, 1.80000000000001, 1.80000000000001, 1.80000000000001, 
    1.80000000000001, 2.60000000000001, 2.60000000000001, 2.60000000000001, 
    2.60000000000001, 2.60000000000001, 2.60000000000001, 3.20000000000001, 
    3.20000000000001, 3.20000000000001, 3.20000000000001, 3.20000000000001, 
    3.20000000000001, 4.00000000000001, 4.00000000000001, 4.00000000000001, 
    4.00000000000001, 4.00000000000001, 4.00000000000001, 4.60000000000001, 
    4.60000000000001, 4.60000000000001, 4.60000000000001, 4.60000000000001, 
    4.60000000000001, 5.40000000000001, 5.40000000000001, 5.40000000000001, 
    5.40000000000001, 5.40000000000001, 5.40000000000001, 6.00000000000001, 
    6.00000000000001, 6.00000000000001, 6.00000000000001, 6.00000000000001, 
    6.00000000000001, 6.80000000000001, 6.80000000000001, 6.80000000000001, 
    6.80000000000001, 6.80000000000001, 6.80000000000001, 7.40000000000001, 
    7.40000000000001, 7.40000000000001, 7.40000000000001, 7.40000000000001, 
    7.40000000000001, 8.20000000000001, 8.20000000000001, 8.20000000000001, 
    8.20000000000001, 8.20000000000001, 8.20000000000001, 8.80000000000001, 
    8.80000000000001, 8.80000000000001, 8.80000000000001, 8.80000000000001, 
    8.80000000000001, 9.40000000000001, 9.40000000000001, 9.40000000000001, 
    9.40000000000001, 9.40000000000001, 9.40000000000001, 10.091789367799, 
    10.091789367799, 10.091789367799, 10.091789367799, 10.091789367799, 
    10.091789367799 ;
}

ncdump -v ssh init.nc | tail -n 50

 ssh =
  8.607000007, 8.607000007, 8.607000007, 8.607000007, 8.607000007, 
    8.607000007, 7.811000011, 7.811000011, 7.811000011, 7.811000011, 
    7.811000011, 7.811000011, 7.214000014, 7.214000014, 7.214000014, 
    7.214000014, 7.214000014, 7.214000014, 6.418000018, 6.418000018, 
    6.418000018, 6.418000018, 6.418000018, 6.418000018, 5.821000021, 
    5.821000021, 5.821000021, 5.821000021, 5.821000021, 5.821000021, 
    5.025000025, 5.025000025, 5.025000025, 5.025000025, 5.025000025, 
    5.025000025, 4.428000028, 4.428000028, 4.428000028, 4.428000028, 
    4.428000028, 4.428000028, 3.632000032, 3.632000032, 3.632000032, 
    3.632000032, 3.632000032, 3.632000032, 3.035000035, 3.035000035, 
    3.035000035, 3.035000035, 3.035000035, 3.035000035, 2.239000039, 
    2.239000039, 2.239000039, 2.239000039, 2.239000039, 2.239000039, 
    1.642000042, 1.642000042, 1.642000042, 1.642000042, 1.642000042, 
    1.642000042, 0.846000045999995, 0.846000045999995, 0.846000045999995, 
    0.846000045999995, 0.846000045999995, 0.846000045999995, 
    0.249000048999994, 0.249000048999994, 0.249000048999994, 
    0.249000048999994, 0.249000048999994, 0.249000048999994, 
    -0.347999948000006, -0.347999948000006, -0.347999948000006, 
    -0.347999948000006, -0.347999948000006, -0.347999948000006, 
    -1.14399994400001, -1.14399994400001, -1.14399994400001, 
    -1.14399994400001, -1.14399994400001, -1.14399994400001, 
    -1.74099994100001, -1.74099994100001, -1.74099994100001, 
    -1.74099994100001, -1.74099994100001, -1.74099994100001, 
    -2.53699993700001, -2.53699993700001, -2.53699993700001, 
    -2.53699993700001, -2.53699993700001, -2.53699993700001, 
    -3.13399993400001, -3.13399993400001, -3.13399993400001, 
    -3.13399993400001, -3.13399993400001, -3.13399993400001, 
    -3.92999993000001, -3.92999993000001, -3.92999993000001, 
    -3.92999993000001, -3.92999993000001, -3.92999993000001, 
    -4.52699992700001, -4.52699992700001, -4.52699992700001, 
    -4.52699992700001, -4.52699992700001, -4.52699992700001, 
    -5.32299992300001, -5.32299992300001, -5.32299992300001, 
    -5.32299992300001, -5.32299992300001, -5.32299992300001, 
    -5.91999992000001, -5.91999992000001, -5.91999992000001, 
    -5.91999992000001, -5.91999992000001, -5.91999992000001, 
    -6.71599991600001, -6.71599991600001, -6.71599991600001, 
    -6.71599991600001, -6.71599991600001, -6.71599991600001, 
    -7.31299991300001, -7.31299991300001, -7.31299991300001, 
    -7.31299991300001, -7.31299991300001, -7.31299991300001, 
    -8.10899990900001, -8.10899990900001, -8.10899990900001, 
    -8.10899990900001, -8.10899990900001, -8.10899990900001, 
    -8.70599990600001, -8.70599990600001, -8.70599990600001, 
    -8.70599990600001, -8.70599990600001, -8.70599990600001, 
    -9.30299990300001, -9.30299990300001, -9.30299990300001, 
    -9.30299990300001, -9.30299990300001, -9.30299990300001, 
    -9.99178926779897, -9.99178926779897, -9.99178926779897, 
    -9.99178926779897, -9.99178926779897, -9.99178926779897 ;
}

@pwolfram
Copy link
Contributor Author

pwolfram commented Feb 26, 2020

@mark-petersen, this was the test case we discussed in person a few weeks ago following your fix in #317

@pwolfram
Copy link
Contributor Author

pwolfram commented Mar 2, 2020

@mark-petersen, can you please review so that we can merge?

mark-petersen
mark-petersen approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these are all just for test cases, so is fine, based on your posted results. Please merge. Sorry for the delay.

@pwolfram pwolfram merged commit db21064 into MPAS-Dev:ocean/coastal Mar 2, 2020
@pwolfram pwolfram deleted the coastal/wetting_drying_above_land branch March 2, 2020 20:26
@pwolfram
Copy link
Contributor Author

pwolfram commented Mar 2, 2020

Thanks @mark-petersen!

@pwolfram pwolfram mentioned this pull request Apr 2, 2020
Closed
@pwolfram pwolfram mentioned this pull request Apr 14, 2020
Merged
pwolfram added a commit to pwolfram/MPAS-Model that referenced this pull request Jun 4, 2020
@pwolfram
Fixes vertical mesh error for surface_waves case
b1fc468 
Fixes bug introduced in MPAS-Dev#456
where vertical mesh incorrectly assumes on-land and below-water slopes
between left and right boundary
@pwolfram pwolfram mentioned this pull request Jun 4, 2020
Merged
sbrus89 pushed a commit to sbrus89/MPAS-Model that referenced this pull request Jul 29, 2020
@pwolfram
Fixes vertical mesh error for surface_waves case
12654b5 
Fixes bug introduced in MPAS-Dev#456
where vertical mesh incorrectly assumes on-land and below-water slopes
between left and right boundary
sbrus89 pushed a commit to sbrus89/MPAS-Model that referenced this pull request Aug 14, 2020
@pwolfram
Fixes vertical mesh error for surface_waves case
d9a4dc7 
Fixes bug introduced in MPAS-Dev#456
where vertical mesh incorrectly assumes on-land and below-water slopes
between left and right boundary
sbrus89 pushed a commit that referenced this pull request Aug 19, 2020
@pwolfram
Fixes vertical mesh error for surface_waves case
cecd13a 
Fixes bug introduced in #456
where vertical mesh incorrectly assumes on-land and below-water slopes
between left and right boundary
mark-petersen pushed a commit to mark-petersen/MPAS-Model that referenced this pull request Jan 11, 2021
@pwolfram
Fixes vertical mesh error for surface_waves case
25226d1 
Fixes bug introduced in MPAS-Dev#456
where vertical mesh incorrectly assumes on-land and below-water slopes
between left and right boundary
jonbob pushed a commit to E3SM-Project/E3SM that referenced this pull request Jun 22, 2021
@pwolfram
Fixes vertical mesh error for surface_waves case
b5f71cd 
Fixes bug introduced in MPAS-Dev/MPAS-Model#456
where vertical mesh incorrectly assumes on-land and below-water slopes
between left and right boundary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mark-petersen mark-petersen mark-petersen approved these changes

Assignees

No one assigned

Labels

coastal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pwolfram @mark-petersen @matthewhoffman