-
Notifications
You must be signed in to change notification settings - Fork 388
Adds Ocean Heat Content AM #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Ocean Heat Content AM #455
Conversation
|
I've added four arrays (nCells dimension) |
|
@vanroekel: we normally compute the OHC from the layerWeigthedAvg AM (and then define the depth ranges over which to do the accumulated quantity through the MPAS-Analysis config file). So I am not sure why we need this AM? Does the layerWeigthedAvg AM have a problem? |
|
my read of that AM is it can do the globally averaged OHC, this returns a horizontal map. This PR is needed to return the map but more importantly for work on a LDRD-DR effort where we want to compute the 2-D maps at high frequency while the model runs and do statistics on the data. |
|
Indeed the layerWeightedAvg AM computes quantities over specified regions (including the global region). I was thinking that we could potentially modify it, to output the T and S content globally over specified depth ranges, but perhaps better to keep things separate. So I assume this AM does what your postprocessing script does to get the global maps? |
a251a7f to
66e5b41
Compare
|
rebased. Added this AM and output variables to analysis test in nightly regression suite. On above comments, it sounds like this AM is sufficiently different from others. If it is useful, it's fine to have some redundancy between AMs and MPAS-Analysis. We can also write these out at higher frequency. |
|
This can can be merged in next week. It requires E3SM flag additions, so will be put in an E3SM PR for that. |
mark-petersen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turned this AM on in QU240 analysis test. Passes gnu/optimized and intel/debug.
Adds the ability to calculate ocean heat content in the forward model It computes heat content over standard layers 0-700m 700-2000m 2000m - bot full Depth
66e5b41 to
3a5dcab
Compare
|
Rebased. Passes nightly regression with gnu and intel/debug, including this AM in the analysis test. |
|
@xylar and @milenaveneziani I would like to merge this. Do you have any comments? |
|
Sorry, I didn't realize my review had been requested. I don't have any input so will take myself off as a reviewer. |
Update mpas-source: analysis member update, remove unused modules This PR brings in a new mpas-source submodule with changes only to the ocean, including several updates to analysis members and removing modules that are not used in E3SM simulations: * Adds normalVelocity arrays to eddy products (MPAS-Dev/MPAS-Model#544) * Adds Ocean Heat Content AM (MPAS-Dev/MPAS-Model#455) * Ocean/remove unused modules (MPAS-Dev/MPAS-Model#569) It includes corresponding changes to E3SM namelists and streams files for MPAS-Ocean. COMPASS changes associated with these PRs are also included. [NML] [BFB]
…3613) Update mpas-source: analysis member update, remove unused modules Re-merged after fixes for debug failures, excess output This PR brings in a new mpas-source submodule with changes only to the ocean, including several updates to analysis members and removing modules that are not used in E3SM simulations: * Adds normalVelocity arrays to eddy products (MPAS-Dev/MPAS-Model#544) * Adds Ocean Heat Content AM (MPAS-Dev/MPAS-Model#455) * Ocean/remove unused modules (MPAS-Dev/MPAS-Model#569) It includes corresponding changes to E3SM namelists and streams files for MPAS-Ocean. COMPASS changes associated with these PRs are also included. [NML] [BFB]
Update mpas-source: analysis member update, remove unused modules This PR brings in a new mpas-source submodule with changes only to the ocean, including several updates to analysis members and removing modules that are not used in E3SM simulations: * Adds normalVelocity arrays to eddy products (MPAS-Dev/MPAS-Model#544) * Adds Ocean Heat Content AM (MPAS-Dev/MPAS-Model#455) * Ocean/remove unused modules (MPAS-Dev/MPAS-Model#569) It includes corresponding changes to E3SM namelists and streams files for MPAS-Ocean. COMPASS changes associated with these PRs are also included. [NML] [BFB]
…ean/develop Adds Ocean Heat Content AM MPAS-Dev#455 Adds the ability to calculate ocean heat content during a forward model run It computes heat content over standard layers 0-700m 700-2000m 2000m - bot full Depth

Adds the ability to calculate ocean heat content during a forward model run
It computes heat content over standard layers
0-700m
700-2000m
2000m - bot
full Depth