Skip to content

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Jan 26, 2020

Near as I can tell, this script is not used and the test case works without it.

closes #431

@xylar
Copy link
Collaborator Author

xylar commented Jan 26, 2020

@sbrus89, should this go to ocean/coastal or is ocean/develop the right place?

@pwolfram
Copy link
Contributor

pwolfram commented Jan 26, 2020 via email

@xylar xylar changed the base branch from ocean/develop to ocean/coastal January 26, 2020 05:55
@xylar xylar force-pushed the ocean/remove_broken_jigsaw_link branch from 43c6bbc to dd27d1e Compare January 26, 2020 05:57
@xylar
Copy link
Collaborator Author

xylar commented Jan 26, 2020

@pwolfram, done.

@xylar xylar removed the Ocean label Jan 26, 2020
Copy link

@sbrus89 sbrus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar, Thanks for catching this and cleaning it up. You're right that this link isn't necessary.

@xylar
Copy link
Collaborator Author

xylar commented Feb 11, 2020

@mark-petersen, this is just clean-up and should be merged as soon as convenient.

Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, thanks.

@mark-petersen mark-petersen removed the request for review from pwolfram February 12, 2020 13:45
mark-petersen added a commit that referenced this pull request Feb 12, 2020
Near as I can tell, this script is not used and the test case works
without it.

closes #431
@mark-petersen mark-petersen merged commit dd27d1e into MPAS-Dev:ocean/coastal Feb 12, 2020
@xylar xylar deleted the ocean/remove_broken_jigsaw_link branch May 19, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants