Skip to content

Adds West coast mesh from SF to LA #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pwolfram merged 2 commits into from
Jan 16, 2020
Merged

Adds West coast mesh from SF to LA #424

pwolfram merged 2 commits into from
Jan 16, 2020

Conversation

@pwolfram
Copy link
Contributor

@pwolfram pwolfram commented Jan 15, 2020 •
edited
Loading

Adds an example West coast and HI mesh

@pwolfram pwolfram requested a review from sbrus89 January 15, 2020 16:36
@pwolfram
Copy link
Contributor Author

pwolfram commented Jan 15, 2020

image

Note background land is just a quick ParaView plotting hack to show relative location to CA coast.

@pwolfram
Copy link
Contributor Author

pwolfram commented Jan 15, 2020

cc @mark-petersen, @sbrus89 this is just a mesh.

Big thing to check is path naming: compass/ocean/CArefined/120km3km/.

Visual approval should be ok and we should all agree on CArefined tag at ocean top level.

@mark-petersen
Copy link
Contributor

mark-petersen commented Jan 15, 2020

Could we change the path
testing_and_setup/compass/ocean/CArefined/120km3km/build_mesh
to
testing_and_setup/compass/ocean/global_ocean/CA120to3/init
Everything on a full sphere is in the global_ocean subdirectory.

@pwolfram
Copy link
Contributor Author

pwolfram commented Jan 15, 2020

cc @cajeffery

@pwolfram
Copy link
Contributor Author

pwolfram commented Jan 15, 2020

@mark-petersen, we aren't running a simulation so would

testing_and_setup/compass/ocean/global_ocean/CA120to3/build_mesh work?

Otherwise, we would have an incomplete init and we are moving toward a separated mesh building step for other parts of the coastal code, to allow for faster iteration if the init doesn't explicitly depend on the mesh, which it usually doesn't.

@pwolfram
Copy link
Contributor Author

pwolfram commented Jan 15, 2020

cc @markgalassi

@sbrus89
Copy link

sbrus89 commented Jan 15, 2020

I like the testing_and_setup/compass/ocean/global_ocean/CA120to3/build_mesh path

sbrus89
sbrus89 reviewed Jan 15, 2020
View reviewed changes
Copy link

@sbrus89 sbrus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pwolfram, this looks great. Just one minor comment.

@pwolfram pwolfram force-pushed the coastal/CAcoastMesh branch from a2f7239 to b40fe33 Compare January 16, 2020 20:53
@pwolfram
Copy link
Contributor Author

pwolfram commented Jan 16, 2020

image
HI patch-based mesh example.

@pwolfram
Copy link
Contributor Author

pwolfram commented Jan 16, 2020

@mark-petersen, @sbrus89, @cajeffrey, do you have additional recommendations before a merge?

mark-petersen
mark-petersen approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and merge, thanks.

pwolfram added a commit that referenced this pull request Jan 16, 2020
@pwolfram
Merge #424 'coastal/CAcoastMesh' into ocean/coastal
e4f2608 
Adds examples of JIGSAW workflow for coastal cases.
  Adds HI refined case
  West coast mesh from SF to LA
@pwolfram pwolfram merged commit b40fe33 into MPAS-Dev:ocean/coastal Jan 16, 2020
@pwolfram pwolfram deleted the coastal/CAcoastMesh branch January 16, 2020 23:44
@pwolfram
Copy link
Contributor Author

pwolfram commented Jan 16, 2020

Thanks, we can update a minor fix in a future PR as needed. This way folks can use the ocean/coastal branch to move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mark-petersen mark-petersen mark-petersen approved these changes

+1 more reviewer

@sbrus89 sbrus89 sbrus89 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

coastal COMPASS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pwolfram @mark-petersen @sbrus89 @matthewhoffman