Add mpas_in_cell, mpas_mirror_point, and mpas_rotate_about_vector to operators#400
Merged
mgduda merged 1 commit intoMPAS-Dev:developfrom Jan 10, 2020
Merged
Conversation
…operators
Three new routines, mpas_in_cell, mpas_mirror_point, and mpas_rotate_about_vector
are added to the mpas_geometry_utils module. Briefly, the routines provide
the following:
* mpas_in_cell: Given the Voronoi center and corner points of a cell, determine
whether a point is inside the Voronoi cell
* mpas_mirror_point: Given a point and a great-circle arc, find the mirror of
the point on the other side of the arc
* mpas_rotate_about_vector: Given a vector in R3 and a point, rotate the point
by a specified angle about the vector
mark-petersen
approved these changes
Dec 4, 2019
Contributor
mark-petersen
left a comment
mark-petersen
left a comment
There was a problem hiding this comment.
These look like nice clean routines. I did a local merge and compiled with intel and gnu on LANL IC, but did not test functionality.
I assume that if you had to call these for a large number of points you would want to in-line the code within a larger loop for performance, but it's great to have the routines here regardless.
Contributor
Author
|
@matthewhoffman @akturner Did you have any objections or comments for this PR? If not, I'll go ahead and merge it at the end of this week (10 January). |
matthewhoffman
approved these changes
Jan 9, 2020
mgduda
added a commit
that referenced
this pull request
Jan 10, 2020
This merge adds three new routines, mpas_in_cell, mpas_mirror_point, and mpas_rotate_about_vector, to the mpas_geometry_utils module. Briefly, the routines provide the following: - mpas_in_cell: Given the Voronoi center and corner points of a cell, determine whether a point is inside the Voronoi cell - mpas_mirror_point: Given a point and a great-circle arc, find the mirror of the point on the other side of the arc - mpas_rotate_about_vector: Given a vector in R3 and a point, rotate the point by a specified angle about the vector * operators/add_mpas_in_cell: Add mpas_in_cell, mpas_mirror_point, and mpas_rotate_about_vector to operators
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Jul 27, 2020
#3737) Update MPAS framework This PR brings in a new mpas-source submodule with updates to the mpas framework itself, plus changes to the cores supporting the framework update. Some changes are made to the atmosphere core, even though it is not used by E3SM, in order to maintain consistency with the framework. This update includes the following individual branches and PRs, many of which are additions to the makefiles for summit, or optional libraries: * az/azamat/mpas-cmake/mpas-tool-dir (MPAS-Dev/MPAS-Model#629) * init_atmosphere/kd_tree_ties (MPAS-Dev/MPAS-Model#630) * mark-petersen/framework/add_FillValue (MPAS-Dev/MPAS-Model#616) * mark-petersen/framework/add_lapack_option (MPAS-Dev/MPAS-Model#613) * amametjanov/framework/nullify-field-pointers (MPAS-Dev/MPAS-Model#578) * framework/makefile_e3sm (MPAS-Dev/MPAS-Model#603) * xylar/framework/make_shell_bash (MPAS-Dev/MPAS-Model#594) * registry/missing_value (MPAS-Dev/MPAS-Model#562) * pwolfram/updates_make_intel_stack (MPAS-Dev/MPAS-Model#592) * azamat/framework/pgi-cpr-omp-workaround (MPAS-Dev/MPAS-Model#449) * az/framework/e3sm-cmake-qnosmp-typo (MPAS-Dev/MPAS-Model#579) * xylar/compass/add_prerequisite_tag * atmosphere/fix_timekeeping_imports (MPAS-Dev/MPAS-Model#582) * xylar/fix_docs_ci (MPAS-Dev/MPAS-Model#575) * xylar/add_compass_docs (MPAS-Dev/MPAS-Model#472) * philipwjones/framework/summitmake (MPAS-Dev/MPAS-Model#536) * atmosphere/atm_core_cleanup (MPAS-Dev/MPAS-Model#548) * init_atmosphere/parse_geoindex (MPAS-Dev/MPAS-Model#459) * xylar/compass/add_copy_file (MPAS-Dev/MPAS-Model#467) * init_atmosphere/kd_tree (MPAS-Dev/MPAS-Model#438) * init_atmosphere/mpas_stack (MPAS-Dev/MPAS-Model#426) * operators/add_mpas_in_cell (MPAS-Dev/MPAS-Model#400) Fixes #3396 Fixes #3236 [BFB]
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Jul 29, 2020
Update MPAS framework This PR brings in a new mpas-source submodule with updates to the mpas framework itself, plus changes to the cores supporting the framework update. Some changes are made to the atmosphere core, even though it is not used by E3SM, in order to maintain consistency with the framework. This update includes the following individual branches and PRs, many of which are additions to the makefiles for summit, or optional libraries: * az/azamat/mpas-cmake/mpas-tool-dir (MPAS-Dev/MPAS-Model#629) * init_atmosphere/kd_tree_ties (MPAS-Dev/MPAS-Model#630) * mark-petersen/framework/add_FillValue (MPAS-Dev/MPAS-Model#616) * mark-petersen/framework/add_lapack_option (MPAS-Dev/MPAS-Model#613) * amametjanov/framework/nullify-field-pointers (MPAS-Dev/MPAS-Model#578) * framework/makefile_e3sm (MPAS-Dev/MPAS-Model#603) * xylar/framework/make_shell_bash (MPAS-Dev/MPAS-Model#594) * registry/missing_value (MPAS-Dev/MPAS-Model#562) * pwolfram/updates_make_intel_stack (MPAS-Dev/MPAS-Model#592) * azamat/framework/pgi-cpr-omp-workaround (MPAS-Dev/MPAS-Model#449) * az/framework/e3sm-cmake-qnosmp-typo (MPAS-Dev/MPAS-Model#579) * xylar/compass/add_prerequisite_tag * atmosphere/fix_timekeeping_imports (MPAS-Dev/MPAS-Model#582) * xylar/fix_docs_ci (MPAS-Dev/MPAS-Model#575) * xylar/add_compass_docs (MPAS-Dev/MPAS-Model#472) * philipwjones/framework/summitmake (MPAS-Dev/MPAS-Model#536) * atmosphere/atm_core_cleanup (MPAS-Dev/MPAS-Model#548) * init_atmosphere/parse_geoindex (MPAS-Dev/MPAS-Model#459) * xylar/compass/add_copy_file (MPAS-Dev/MPAS-Model#467) * init_atmosphere/kd_tree (MPAS-Dev/MPAS-Model#438) * init_atmosphere/mpas_stack (MPAS-Dev/MPAS-Model#426) * operators/add_mpas_in_cell (MPAS-Dev/MPAS-Model#400) Fixes #3396 Fixes #3236 [BFB]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge adds three new routines, mpas_in_cell, mpas_mirror_point, and
mpas_rotate_about_vector, to the mpas_geometry_utils module.
Briefly, the routines provide the following:
mpas_in_cell: Given the Voronoi center and corner points of a cell, determine
whether a point is inside the Voronoi cell
mpas_mirror_point: Given a point and a great-circle arc, find the mirror of
the point on the other side of the arc
mpas_rotate_about_vector: Given a vector in R3 and a point, rotate the point
by a specified angle about the vector