Skip to content

Conversation

@mark-petersen
Copy link
Contributor

These three 3D variables are in the Registry, and one is obtained, but none are used. Git blame shows they were added by Todd and Doug in 2013, but then Qingshan Chen added his own naming scheme for GM.

@mark-petersen
Copy link
Contributor Author

This is part of a larger effort to reduce the memory footprint of MPAS-Ocean, as we have egregious overuse of memory due to lack of care (myself included). This is an obvious one.

I started looking at memory use when an 18to6 run with LIGHT had 'out of memory' errors until we went up to 16k cores, and we had to reduce it.

Copy link
Contributor

@vanroekel vanroekel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved by visual inspection

@mark-petersen
Copy link
Contributor Author

@hrmoncada, please practice your bit-for-bit tests on this PR. Also, do a memory test to report the total memory footprint before/after this PR. Possible tools are intel VTune, perf, and intel advisor. Thanks.

@hrmoncada
Copy link

hrmoncada commented Oct 1, 2019

@mark-petersen I will, thanks

@hrmoncada
Copy link

hrmoncada commented Oct 2, 2019

@mark-petersen I can not take your configuration ocean file

gr-fe1:compass$ take /usr/projects/climate/mpeterse/repos/model/ocean_develop/testing_and_setup/compass/general.config.ocean_hrmoncada
Cannot find giver's account information.

@hrmoncada
Copy link

@mark-petersen never mind, I got the file :)

mark-petersen added a commit that referenced this pull request Oct 23, 2019
These three 3D variables are in the Registry, and one is obtained, but
none are used. Git blame shows they were added by Todd and Doug in 2013,
but then Qingshan Chen added his own naming scheme for GM.
@mark-petersen mark-petersen merged commit 4f478fd into MPAS-Dev:ocean/develop Oct 23, 2019
@mark-petersen mark-petersen deleted the ocean/reduce_memory branch October 23, 2019 13:40
ashwathsv pushed a commit to ashwathsv/MPAS-Model that referenced this pull request Jul 21, 2020
These three 3D variables are in the Registry, and one is obtained, but
none are used. Git blame shows they were added by Todd and Doug in 2013,
but then Qingshan Chen added his own naming scheme for GM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants