-
Notifications
You must be signed in to change notification settings - Fork 390
Remove unused variables hEddyFlux,hKappa,hKappaQ #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused variables hEddyFlux,hKappa,hKappaQ #368
Conversation
|
This is part of a larger effort to reduce the memory footprint of MPAS-Ocean, as we have egregious overuse of memory due to lack of care (myself included). This is an obvious one. I started looking at memory use when an 18to6 run with LIGHT had 'out of memory' errors until we went up to 16k cores, and we had to reduce it. |
vanroekel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved by visual inspection
|
@hrmoncada, please practice your bit-for-bit tests on this PR. Also, do a memory test to report the total memory footprint before/after this PR. Possible tools are intel VTune, perf, and intel advisor. Thanks. |
|
@mark-petersen I will, thanks |
|
@mark-petersen I can not take your configuration ocean file gr-fe1:compass$ take /usr/projects/climate/mpeterse/repos/model/ocean_develop/testing_and_setup/compass/general.config.ocean_hrmoncada |
|
@mark-petersen never mind, I got the file :) |
55bc14c to
4f478fd
Compare
These three 3D variables are in the Registry, and one is obtained, but none are used. Git blame shows they were added by Todd and Doug in 2013, but then Qingshan Chen added his own naming scheme for GM.
These three 3D variables are in the Registry, and one is obtained, but none are used. Git blame shows they were added by Todd and Doug in 2013, but then Qingshan Chen added his own naming scheme for GM.
These three 3D variables are in the Registry, and one is obtained, but none are used. Git blame shows they were added by Todd and Doug in 2013, but then Qingshan Chen added his own naming scheme for GM.