Skip to content

Conversation

@pwolfram
Copy link
Contributor

@pwolfram pwolfram commented Sep 5, 2019

Adds a test case for Gaussian hump idealized "hurricane" for real-world bathymetry to demonstrate stability of wetting and drying with flooding on land in a more realistic real-world case than the drying slope test case.

 * Updates output reporting for drying cells
 * Fixes output message typo
Allows initialization of an idealized "hurricane"
via use of a Gaussian hump that does not require
time-varying forcing for testing purposes.
@pwolfram
Copy link
Contributor Author

pwolfram commented Sep 5, 2019

Testing with Gaussian hump with amplitude of 4m:

Initial at t=0 hrs:

image
image

At 4 hrs:

image
image

Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by visual inspection. Only forward mode file is to add lat/lon variables.

All others are init mode files or COMPASS, so if it works for you that is fine. I will do careful testing when merging the coastal branch. Please merge.

@pwolfram
Copy link
Contributor Author

pwolfram commented Sep 5, 2019

image

Note, bathymetry and vertical coordinate system is shifted to avoid instability with bottomDepth < 0, as discussed earlier @mark-petersen.

@pwolfram
Copy link
Contributor Author

pwolfram commented Sep 5, 2019

@sbrus89, can you please test and verify that this works for you? I'm also running your Sandy test case to ensure that it works as expected following these changes.

@pwolfram
Copy link
Contributor Author

pwolfram commented Sep 5, 2019

@mark-petersen, we will verify that Sandy case is intact and then merge. Thanks!

@pwolfram
Copy link
Contributor Author

pwolfram commented Sep 5, 2019

@sbrus89, here is the result from the sandy case, which is stable, but doesn't appear to be as good as some of the recent runs we've done based on plots we've made. All plots are out of QuickViz on the pointStats.

8536110

Are the parameters in the namelist.ocean file in the repo the best ones we have? I don't think they are because config_use_const_visc=.false., for instance.

Thus, because this is stable I'm inclined to think it is working and we should have a separate PR to deal with tuning the Sandy case.

Please let me know what you think but I'm inclined to think this is ready to merge and you should do a separate PR to submit the tuned results that we anticipate to be better for Sandy.

@pwolfram
Copy link
Contributor Author

pwolfram commented Sep 7, 2019

Using `ocean/coastal' yield the following result, which is qualitatively equivalent to the above (noting I've removed the superflous modification of Bahama bathymetry so results aren't expected to be BFB.

8536110

Given these results I'll merge this PR and we can fine tune the existing Sandy simulation in a follow-up PR (e.g., using the depth-averaging approach that produces a better match against the data).

@pwolfram pwolfram removed the request for review from sbrus89 September 7, 2019 01:53
@pwolfram pwolfram self-assigned this Sep 7, 2019
pwolfram added a commit that referenced this pull request Sep 7, 2019
…astal

Adds Gaussian hump initialization to Sandy case
@pwolfram pwolfram merged commit cffd78b into MPAS-Dev:ocean/coastal Sep 7, 2019
@pwolfram pwolfram deleted the coastal/Delaware_gaussian_hump_PR branch September 7, 2019 01:59
mark-petersen added a commit that referenced this pull request Oct 19, 2019
This PR is an accumulation of PRs into the ocean/coastal branch. We are
bringing them in at once for efficiency:
 #285, #289, #284, #295, #310, #311, #312, #335, #354, #356, #358, #359,
 #365, #371
mark-petersen added a commit that referenced this pull request Oct 19, 2019
This PR is an accumulation of PRs into the ocean/coastal branch. We are
bringing them in at once for efficiency.
 #285, #289, #284, #295, #310, #311, #312, #335, #354, #356, #358, #359,
 #365, #371
ashwathsv pushed a commit to ashwathsv/MPAS-Model that referenced this pull request Jul 21, 2020
…ocean/coastal

Adds Gaussian hump initialization to Sandy case
ashwathsv pushed a commit to ashwathsv/MPAS-Model that referenced this pull request Jul 21, 2020
mark-petersen added a commit to mark-petersen/MPAS-Model that referenced this pull request Jan 11, 2021
caozd999 pushed a commit to caozd999/MPAS-Model that referenced this pull request Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants