-
Notifications
You must be signed in to change notification settings - Fork 388
Adds wetting and drying Gaussian hump test cases #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds wetting and drying Gaussian hump test cases #359
Conversation
* Updates output reporting for drying cells * Fixes output message typo
Allows initialization of an idealized "hurricane" via use of a Gaussian hump that does not require time-varying forcing for testing purposes.
mark-petersen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved by visual inspection. Only forward mode file is to add lat/lon variables.
All others are init mode files or COMPASS, so if it works for you that is fine. I will do careful testing when merging the coastal branch. Please merge.
|
Note, bathymetry and vertical coordinate system is shifted to avoid instability with |
|
@sbrus89, can you please test and verify that this works for you? I'm also running your Sandy test case to ensure that it works as expected following these changes. |
|
@mark-petersen, we will verify that Sandy case is intact and then merge. Thanks! |
|
@sbrus89, here is the result from the sandy case, which is stable, but doesn't appear to be as good as some of the recent runs we've done based on plots we've made. All plots are out of QuickViz on the pointStats. Are the parameters in the namelist.ocean file in the repo the best ones we have? I don't think they are because Thus, because this is stable I'm inclined to think it is working and we should have a separate PR to deal with tuning the Sandy case. Please let me know what you think but I'm inclined to think this is ready to merge and you should do a separate PR to submit the tuned results that we anticipate to be better for Sandy. |
|
Using `ocean/coastal' yield the following result, which is qualitatively equivalent to the above (noting I've removed the superflous modification of Bahama bathymetry so results aren't expected to be BFB. Given these results I'll merge this PR and we can fine tune the existing Sandy simulation in a follow-up PR (e.g., using the depth-averaging approach that produces a better match against the data). |
…astal Adds Gaussian hump initialization to Sandy case
…ocean/coastal Adds Gaussian hump initialization to Sandy case
This PR is an accumulation of PRs into the ocean/coastal branch. We are bringing them in at once for efficiency: MPAS-Dev#285, MPAS-Dev#289, MPAS-Dev#284, MPAS-Dev#295, MPAS-Dev#310, MPAS-Dev#311, MPAS-Dev#312, MPAS-Dev#335, MPAS-Dev#354, MPAS-Dev#356, MPAS-Dev#358, MPAS-Dev#359, MPAS-Dev#365, MPAS-Dev#371
This PR is an accumulation of PRs into the ocean/coastal branch. We are bringing them in at once for efficiency: MPAS-Dev#285, MPAS-Dev#289, MPAS-Dev#284, MPAS-Dev#295, MPAS-Dev#310, MPAS-Dev#311, MPAS-Dev#312, MPAS-Dev#335, MPAS-Dev#354, MPAS-Dev#356, MPAS-Dev#358, MPAS-Dev#359, MPAS-Dev#365, MPAS-Dev#371
This PR is an accumulation of PRs into the ocean/coastal branch. We are bringing them in at once for efficiency: MPAS-Dev#285, MPAS-Dev#289, MPAS-Dev#284, MPAS-Dev#295, MPAS-Dev#310, MPAS-Dev#311, MPAS-Dev#312, MPAS-Dev#335, MPAS-Dev#354, MPAS-Dev#356, MPAS-Dev#358, MPAS-Dev#359, MPAS-Dev#365, MPAS-Dev#371







Adds a test case for Gaussian hump idealized "hurricane" for real-world bathymetry to demonstrate stability of wetting and drying with flooding on land in a more realistic real-world case than the drying slope test case.