Skip to content

Adds drying safety factor needed for real-world cases#358

Merged
pwolfram merged 1 commit intoMPAS-Dev:ocean/coastalfrom
pwolfram:coastal/wetting_drying_safetyfactor
Sep 4, 2019
Merged

Adds drying safety factor needed for real-world cases#358
pwolfram merged 1 commit intoMPAS-Dev:ocean/coastalfrom
pwolfram:coastal/wetting_drying_safetyfactor

Conversation

@pwolfram
Copy link
Contributor

@pwolfram pwolfram commented Sep 4, 2019

Adds a safety factor to ensure a layer doesn't drying within a specified neighborhood of the minimum thickness.

@pwolfram pwolfram force-pushed the coastal/wetting_drying_safetyfactor branch from 4a7391e to dd4ad0f Compare September 4, 2019 21:44
@pwolfram
Copy link
Contributor Author

pwolfram commented Sep 4, 2019

@mark-petersen, this is a safety factor that was identified in the Sandy runs as needed to prevent artificial drying of a cell. I'd like to merge this in before we merge in the full Sandy case. I'm currently testing on the drying slope to prove it doesn't do anything deleterious to the wetting and drying behavior.

mark-petersen
mark-petersen approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine, if it worked for you. I would recommend just adding config_drying_safetyfactor rather than config_drying_safetyfactor*eps. Why confuse the factor with another factor of eps? Then you can give it units of meters. Actually, it's not really a factor then - might be better to call it config_drying_safety_height. But those are just suggestions. Do whatever you prefer.

@pwolfram
Adds wetting and drying safety factor for height
ae6d34c 
Ensures that drying isn't allowed to within a neighborhood of
the threshold using namelist option `config_drying_safety_height`.
@pwolfram pwolfram force-pushed the coastal/wetting_drying_safetyfactor branch from dd4ad0f to ae6d34c Compare September 4, 2019 21:56
@pwolfram
Copy link
Contributor Author

pwolfram commented Sep 4, 2019

Thanks @mark-petersen! The suggestion is a great one and I've pushed the change.

@pwolfram
Copy link
Contributor Author

pwolfram commented Sep 4, 2019

Testing

Results are as expected using the drying slope case with 1km sigma coordinate:
dryingslopecomparison

pwolfram added a commit that referenced this pull request Sep 4, 2019
@pwolfram
Merge #358 'coastal/wetting_drying_safetyfactor' into ocean/coastal
62902fb 
Adds wetting and drying safety factor for height
@pwolfram pwolfram merged commit ae6d34c into MPAS-Dev:ocean/coastal Sep 4, 2019
@pwolfram pwolfram deleted the coastal/wetting_drying_safetyfactor branch September 4, 2019 22:15
@pwolfram
Copy link
Contributor Author

pwolfram commented Sep 4, 2019

Thanks @mark-petersen!

@mark-petersen mark-petersen mentioned this pull request Oct 18, 2019
Merged
mark-petersen added a commit that referenced this pull request Oct 19, 2019
@mark-petersen
Merge branch 'ocean/coastal' into ocean/develop
aec7316 
This PR is an accumulation of PRs into the ocean/coastal branch. We are
bringing them in at once for efficiency:
 #285, #289, #284, #295, #310, #311, #312, #335, #354, #356, #358, #359,
 #365, #371
mark-petersen added a commit that referenced this pull request Oct 19, 2019
@mark-petersen
Merge branch 'ocean/develop' into e3sm/develop
75d4cd0 
This PR is an accumulation of PRs into the ocean/coastal branch. We are
bringing them in at once for efficiency.
 #285, #289, #284, #295, #310, #311, #312, #335, #354, #356, #358, #359,
 #365, #371
ashwathsv pushed a commit to ashwathsv/MPAS-Model that referenced this pull request Jul 21, 2020
@pwolfram
Merge MPAS-Dev#358 'coastal/wetting_drying_safetyfactor' into ocean/c…
2e70ff7 
…oastal

Adds wetting and drying safety factor for height
ashwathsv pushed a commit to ashwathsv/MPAS-Model that referenced this pull request Jul 21, 2020
@mark-petersen
Merge branch 'ocean/coastal' into ocean/develop
5663fac 
This PR is an accumulation of PRs into the ocean/coastal branch. We are
bringing them in at once for efficiency:
 MPAS-Dev#285, MPAS-Dev#289, MPAS-Dev#284, MPAS-Dev#295, MPAS-Dev#310, MPAS-Dev#311, MPAS-Dev#312, MPAS-Dev#335, MPAS-Dev#354, MPAS-Dev#356, MPAS-Dev#358, MPAS-Dev#359,
 MPAS-Dev#365, MPAS-Dev#371
mark-petersen added a commit to mark-petersen/MPAS-Model that referenced this pull request Jan 11, 2021
@mark-petersen
Merge branch 'ocean/coastal' into ocean/develop
3a4dc06 
This PR is an accumulation of PRs into the ocean/coastal branch. We are
bringing them in at once for efficiency:
 MPAS-Dev#285, MPAS-Dev#289, MPAS-Dev#284, MPAS-Dev#295, MPAS-Dev#310, MPAS-Dev#311, MPAS-Dev#312, MPAS-Dev#335, MPAS-Dev#354, MPAS-Dev#356, MPAS-Dev#358, MPAS-Dev#359,
 MPAS-Dev#365, MPAS-Dev#371
caozd999 pushed a commit to caozd999/MPAS-Model that referenced this pull request Jan 14, 2021
@mark-petersen
Merge branch 'ocean/coastal' into ocean/develop
18c60ee 
This PR is an accumulation of PRs into the ocean/coastal branch. We are
bringing them in at once for efficiency:
 MPAS-Dev#285, MPAS-Dev#289, MPAS-Dev#284, MPAS-Dev#295, MPAS-Dev#310, MPAS-Dev#311, MPAS-Dev#312, MPAS-Dev#335, MPAS-Dev#354, MPAS-Dev#356, MPAS-Dev#358, MPAS-Dev#359,
 MPAS-Dev#365, MPAS-Dev#371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mark-petersen mark-petersen mark-petersen approved these changes

Assignees

No one assigned

Labels

coastal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pwolfram @mark-petersen @matthewhoffman