COMPASS ocean nightly regression: Add GM and cleanup #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change order of default namelist to be: main; tracer groups; analysis members; init mode
Contributor
Author
|
@vanroekel, if I were quicker I would have added this to your PR #288. I realized today we need to add the flags to COMPASS to test GM for BFB and performance. The other stuff is to just make the output files more readable. I tested the nightly regression suite on this PR and everything works. I think a visual inspection is sufficient here. |
vanroekel
approved these changes
Aug 20, 2019
Contributor
vanroekel
left a comment
vanroekel
left a comment
There was a problem hiding this comment.
looks good to me, approved by visual inspection.
mark-petersen
added a commit
that referenced
this pull request
Aug 20, 2019
* ocean/add_gm_to_compass_testing: Change order of default namelist and suggested COMPASS namelist Add GM flags to COMPASS global ocean test
ashwathsv
pushed a commit
to ashwathsv/MPAS-Model
that referenced
this pull request
Jul 21, 2020
…velop * ocean/add_gm_to_compass_testing: Change order of default namelist and suggested COMPASS namelist Add GM flags to COMPASS global ocean test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, GM was not tested in the nightly regression. This turns on GM for global cases, including the new depth varying piece.
Also, I moved init flags to the end of the default namelist, and changed the suggested forward and init namelist to the full version (namelist.ocean). Now test cases no longer spew the warning
into the log file for every single missing namelist record.