Add Hurricane Sandy test case for Delaware Bay #295

sbrus89 · 2019-06-21T20:30:16Z

Uses CFSR reanalysis wind and pressure data for Hurricane Sandy. The timeseries for these forcings are interpolated onto the mesh in the init step.

Background mesh is QU120 with a 30km enhanced western Atlantic region to better resolve the wind field. The minimum resolution in Delaware Bay is 2km surrounded by successively larger 5 and 10 km regions. The mesh contains 58,111 cells.

There are 60 vertical layers with a z-star coordinate system. Minimum and maximum depths are 30 and 2000m, respectively.
PointwiseStats are recorded ever 0.5 hours at the cell locations nearest to NOAA-COOPS and USGS water level gauges for storm surge validation.

Simulation time frame is between 10/1/2012 - 11/8/2012 to allow for a 20 ramp for the atmospheric forcing. Sandy made landfall on 10/29/2012.
Runs in under 2.5 hours on Grizzly using 360 cores.
Wetting and drying of land is not enabled.
No tidal forcing
There are some spurious oscillations that need to be addressed.

Initial comparisons with observed data aren't great, but look reasonable. Including wetting and drying should improve these results.

mark-petersen · 2019-06-21T21:00:44Z

@sbrus89 Very nice! It's exciting to see your test case with the hurricane forcing!

Please test-compile with both intel and gnu. Compile with one in debug mode and run your test case, as that can pick up some things. Otherwise, all looks good.

sbrus89 · 2019-06-21T21:32:45Z

Thanks @mark-petersen!

I tested with gnu initially, but will do intel and gnu with debug flags. I'll let you know how it goes.

pwolfram

Here are some preliminary comments @sbrus89 -- I'm still reviewing and testing on IC...

src/core_ocean/mode_init/mpas_ocn_init_hurricane.F

src/core_ocean/mode_init/mpas_ocn_init_mode.F

testing_and_setup/compass/ocean/hurricane/USDEQU120at30cr10rr2/sandy/config_forward.xml

testing_and_setup/compass/ocean/hurricane/concatenate_cfsr.py

testing_and_setup/compass/ocean/hurricane/interpolate_time_varying_forcing.py

testing_and_setup/compass/ocean/jigsaw_to_MPAS/inject_bathymetry.py

testing_and_setup/compass/ocean/jigsaw_to_MPAS/inject_preserve_floodplain.py

testing_and_setup/compass/ocean/hurricane/USDEQU120at30cr10rr2/sandy/config_forward.xml

pwolfram · 2019-06-22T19:42:04Z

@sbrus89, did you include the script that produces the comparison plots in this PR? Often I like to do this step in an analysis case / directory.

pwolfram · 2019-06-22T19:45:47Z

Note, model ran cleanly-- just wanted to verify that the results are as expected and comparable to what you got in the plots above- thanks!

pwolfram · 2019-06-22T19:47:33Z

Thanks for the comments @xylar!

sbrus89 · 2019-06-24T16:53:28Z

@pwolfram,

Note, model ran cleanly-- just wanted to verify that the results are as expected and comparable to what you got in the plots above- thanks!

The bouy data files I used for comparison are located here:
/usr/projects/regionalclimate/sbrus/sandy_validation/NOAA-COOPS_stations
/usr/projects/regionalclimate/sbrus/sandy_validation/USGS_stations
(hopefully that's an okay place for them, if not I'm happy to move them elsewhere)

The script I used to generate the plots is in QuickVis:
MPAS-QuickViz/ocean/pointwise_ssh_comparison/plot_ssh.py
There is a yaml input file called plot_ssh.config which just needs to be pointed to your pointwiseStats.nc file

mark-petersen

@sbrus89 if you've tested with both gnu and intel, and run your case through with the debug flag on, then I approve. @pwolfram can merge.

sbrus89 · 2019-06-24T21:03:32Z

@mark-petersen, I tested with intel and gnu debug. Everything looks good.

@pwolfram, I'll squash my last two small commits and then you can merge when you're ready.

- Remove link to ocean_model - Remove link to metis - Use gpmetis

sbrus89 · 2019-06-24T21:09:13Z

Actually, can you hold off @pwolfram?

@xylar, do the changes in my last commit look okay? I made them to be consistent with what you had done to other global_ocean test cases.

pwolfram · 2019-06-24T21:10:49Z

@sbrus89, yes I can hold off-- still want to verify that I can reproduce your figures but have permissions issues still with the files you pointed me to on IC. Maybe we can chat to make sure permissions are open so that I can test?

xylar · 2019-06-24T21:32:08Z

Sorry, I'm traveling tomorrow and have to be up in 7 hours. I'm not going to have time to re-review this. I'm sure what you've go it okay. Don't feel like you need to wait for my feedback.

pwolfram · 2019-06-25T18:31:28Z

@sbrus89, are you ok with me merging now?

sbrus89 · 2019-06-25T22:44:39Z

@pwolfram, I am. Go ahead whenever you're ready.

Adds a COMPASS test case to simulate Hurricane Sandy for Delaware Bay, including use of point stats and validation. * hurricane_squashed: Update COMPASS forwad and init config files Make concatenate_cfsr.py python 3 compatible Fix whitspace issue in mpas_ocn_init_mode.F Add Hurricane Sandy test case for Delaware Bay

This PR is an accumulation of PRs into the ocean/coastal branch. We are bringing them in at once for efficiency: #285, #289, #284, #295, #310, #311, #312, #335, #354, #356, #358, #359, #365, #371

This PR is an accumulation of PRs into the ocean/coastal branch. We are bringing them in at once for efficiency. #285, #289, #284, #295, #310, #311, #312, #335, #354, #356, #358, #359, #365, #371

Adds a COMPASS test case to simulate Hurricane Sandy for Delaware Bay, including use of point stats and validation. * hurricane_squashed: Update COMPASS forwad and init config files Make concatenate_cfsr.py python 3 compatible Fix whitspace issue in mpas_ocn_init_mode.F Add Hurricane Sandy test case for Delaware Bay

This PR is an accumulation of PRs into the ocean/coastal branch. We are bringing them in at once for efficiency: MPAS-Dev#285, MPAS-Dev#289, MPAS-Dev#284, MPAS-Dev#295, MPAS-Dev#310, MPAS-Dev#311, MPAS-Dev#312, MPAS-Dev#335, MPAS-Dev#354, MPAS-Dev#356, MPAS-Dev#358, MPAS-Dev#359, MPAS-Dev#365, MPAS-Dev#371

Adds a COMPASS test case to simulate Hurricane Sandy for Delaware Bay, including use of point stats and validation. * hurricane_squashed: Update COMPASS forwad and init config files Make concatenate_cfsr.py python 3 compatible Fix whitspace issue in mpas_ocn_init_mode.F Add Hurricane Sandy test case for Delaware Bay

This PR is an accumulation of PRs into the ocean/coastal branch. We are bringing them in at once for efficiency: MPAS-Dev#285, MPAS-Dev#289, MPAS-Dev#284, MPAS-Dev#295, MPAS-Dev#310, MPAS-Dev#311, MPAS-Dev#312, MPAS-Dev#335, MPAS-Dev#354, MPAS-Dev#356, MPAS-Dev#358, MPAS-Dev#359, MPAS-Dev#365, MPAS-Dev#371

Adds a COMPASS test case to simulate Hurricane Sandy for Delaware Bay, including use of point stats and validation. * hurricane_squashed: Update COMPASS forwad and init config files Make concatenate_cfsr.py python 3 compatible Fix whitspace issue in mpas_ocn_init_mode.F Add Hurricane Sandy test case for Delaware Bay

This PR is an accumulation of PRs into the ocean/coastal branch. We are bringing them in at once for efficiency: MPAS-Dev#285, MPAS-Dev#289, MPAS-Dev#284, MPAS-Dev#295, MPAS-Dev#310, MPAS-Dev#311, MPAS-Dev#312, MPAS-Dev#335, MPAS-Dev#354, MPAS-Dev#356, MPAS-Dev#358, MPAS-Dev#359, MPAS-Dev#365, MPAS-Dev#371

Add Hurricane Sandy test case for Delaware Bay

34233c3

sbrus89 added COMPASS coastal labels Jun 21, 2019

sbrus89 requested review from mark-petersen and pwolfram June 21, 2019 20:30

sbrus89 assigned pwolfram Jun 21, 2019

pwolfram added the feature label Jun 21, 2019

pwolfram suggested changes Jun 21, 2019

View reviewed changes

Steven Brus added 2 commits June 24, 2019 11:14

Fix whitspace issue in mpas_ocn_init_mode.F

a12cfae

Make concatenate_cfsr.py python 3 compatible

6cdeb8c

xylar approved these changes Jun 24, 2019

View reviewed changes

mark-petersen approved these changes Jun 24, 2019

View reviewed changes

Update COMPASS forwad and init config files

1e4e29e

- Remove link to ocean_model - Remove link to metis - Use gpmetis

pwolfram approved these changes Jun 25, 2019

View reviewed changes

pwolfram merged commit 1e4e29e into MPAS-Dev:ocean/coastal Jun 25, 2019

pwolfram deleted the hurricane_squashed branch July 8, 2019 14:52

mark-petersen mentioned this pull request Oct 18, 2019

Merge coastal features into ocean/develop #384

Merged

matthewhoffman added coastal COMPASS feature labels Mar 17, 2021

Add Hurricane Sandy test case for Delaware Bay #295

Add Hurricane Sandy test case for Delaware Bay #295

Uh oh!

Conversation

sbrus89 commented Jun 21, 2019

Uh oh!

mark-petersen commented Jun 21, 2019

Uh oh!

sbrus89 commented Jun 21, 2019

Uh oh!

pwolfram left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pwolfram commented Jun 22, 2019

Uh oh!

pwolfram commented Jun 22, 2019

Uh oh!

pwolfram commented Jun 22, 2019 via email

Uh oh!

sbrus89 commented Jun 24, 2019

Uh oh!

mark-petersen left a comment

Choose a reason for hiding this comment

Uh oh!

sbrus89 commented Jun 24, 2019

Uh oh!

sbrus89 commented Jun 24, 2019

Uh oh!

pwolfram commented Jun 24, 2019

Uh oh!

xylar commented Jun 24, 2019

Uh oh!

pwolfram commented Jun 25, 2019

Uh oh!

sbrus89 commented Jun 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants