Migrates Rayleigh drag from explicit to implicit #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Good call @mark-petersen -- if this is done by today or Monday does that work? |
Contributor
|
No rush. Anytime next week. |
Previously, Rayleigh drag was implemented explicitly, which meant it was not coupled with vertical mixing. Now, Rayleigh drag is implemented implicitly so that it is directly coupled to implicit vertical mixing.
pwolfram
force-pushed
the
ocean/implicit_Rayleigh_drag
branch
from
895d598 to
6face36
Compare
Contributor
Author
|
Pushed the fixes @mark-petersen, will update the drying slope as a way to test. |
Contributor
Author
|
Results are as expected and as shown to you yesterday (recognizing this is a draft figure that needs to be cleaned up for a new PR for the drying slope as discussed):
|
Contributor
Author
|
@mark-petersen, I think this is ready to merge if it passes your tests. |
mark-petersen
approved these changes
Jun 21, 2019
Contributor
mark-petersen
left a comment
mark-petersen
left a comment
There was a problem hiding this comment.
@pwolfram Go ahead and merge into coastal. It's easier for one person to assemble merges onto a single branch.
pwolfram
added a commit
that referenced
this pull request
Jun 21, 2019
…coastal Migrates Rayleigh drag from explicit to implicit Previously, Rayleigh drag was implemented explicitly, which meant it was not coupled with vertical mixing. Now, Rayleigh drag is implemented implicitly so that it is directly coupled to implicit vertical mixing.
Contributor
Author
|
Thanks @mark-petersen! |
mark-petersen
added a commit
that referenced
this pull request
Oct 19, 2019
mark-petersen
added a commit
that referenced
this pull request
Oct 19, 2019
ashwathsv
pushed a commit
to ashwathsv/MPAS-Model
that referenced
this pull request
Jul 21, 2020
…o ocean/coastal Migrates Rayleigh drag from explicit to implicit Previously, Rayleigh drag was implemented explicitly, which meant it was not coupled with vertical mixing. Now, Rayleigh drag is implemented implicitly so that it is directly coupled to implicit vertical mixing.
ashwathsv
pushed a commit
to ashwathsv/MPAS-Model
that referenced
this pull request
Jul 21, 2020
This PR is an accumulation of PRs into the ocean/coastal branch. We are bringing them in at once for efficiency: MPAS-Dev#285, MPAS-Dev#289, MPAS-Dev#284, MPAS-Dev#295, MPAS-Dev#310, MPAS-Dev#311, MPAS-Dev#312, MPAS-Dev#335, MPAS-Dev#354, MPAS-Dev#356, MPAS-Dev#358, MPAS-Dev#359, MPAS-Dev#365, MPAS-Dev#371
mark-petersen
added a commit
to mark-petersen/MPAS-Model
that referenced
this pull request
Jan 11, 2021
This PR is an accumulation of PRs into the ocean/coastal branch. We are bringing them in at once for efficiency: MPAS-Dev#285, MPAS-Dev#289, MPAS-Dev#284, MPAS-Dev#295, MPAS-Dev#310, MPAS-Dev#311, MPAS-Dev#312, MPAS-Dev#335, MPAS-Dev#354, MPAS-Dev#356, MPAS-Dev#358, MPAS-Dev#359, MPAS-Dev#365, MPAS-Dev#371
caozd999
pushed a commit
to caozd999/MPAS-Model
that referenced
this pull request
Jan 14, 2021
This PR is an accumulation of PRs into the ocean/coastal branch. We are bringing them in at once for efficiency: MPAS-Dev#285, MPAS-Dev#289, MPAS-Dev#284, MPAS-Dev#295, MPAS-Dev#310, MPAS-Dev#311, MPAS-Dev#312, MPAS-Dev#335, MPAS-Dev#354, MPAS-Dev#356, MPAS-Dev#358, MPAS-Dev#359, MPAS-Dev#365, MPAS-Dev#371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Rayleigh drag was implemented explicitly, which
meant it was not coupled with vertical mixing. Now,
Rayleigh drag is implemented implicitly so that it is directly
coupled to implicit vertical mixing.