Adds options for 3d varying GM bolus and 2d varying phase speed #288
Conversation
In the GM bolus calculation, there is a specified diffusivity and phase speed (see Ferrari et al. 2010). Currently MPAS-O assumes these values are fixed in time and space. This PR allows separate flags to enable 2D varying (+time) phase speed (based on the first baroclinic mode phase speed) and a separate flag for 3D (+time) varying diffusivity.
|
This has currently been tested in 5 year normal forced G-cases. Results are here https://portal.nersc.gov/project/acme/lvroekel/GM_20190605_GMtest_Kappa3d_vary_c2.anvil_yr5/ and a baseline is here A full core cycle test is in progress, currently at year 25 |
|
@mark-petersen here is the 3d varying bolus kappa pr. |
|
Design document is here: From the July 10 meeting notes:
From @milenaveneziani: |
|
removing the don't merge label, this is tested in a full core cycle and is flag protected -- default off. |
Having the design doc on Confluence isn't a good idea. It defeats the purpose of open development. Could this be copied as pdf or something to the local directory with design docs? |
|
Ideally we would have design documents with markdown or rst text so that we can readily render them via sphinx to a webpage documentation for the code some day, but I know this is extra work so it may not be worth it in the short term. |
Removes the vertical averaging of the GM kappa bolus diffusivity. Testing shows this functionality is not beneficial to simulations
mark-petersen
left a comment
mark-petersen
left a comment
There was a problem hiding this comment.
Looks good. I merged locally tested regression suite, is bfb with previous on grizzly with gnu.
In the GM bolus calculation, there is a specified diffusivity and phase speed (see Ferrari et al. 2010). Currently MPAS-O assumes these values are fixed in time and space. This PR allows separate flags to enable 2D varying (+time) phase speed (based on the first baroclinic mode phase speed) and a separate flag for 3D (+time) varying diffusivity.
…te_maint1.2 Adds options for 3d varying GM bolus and 2d varying phase speed MPAS-Dev#288 In the GM bolus calculation, there is a specified diffusivity and phase speed (see Ferrari et al. 2010). Currently MPAS-O assumes these values are fixed in time and space. This PR allows separate flags to enable 2D varying (+time) phase speed (based on the first baroclinic mode phase speed) and a separate flag for 3D (+time) varying diffusivity. * pr_test2:dd Removes 2D GM code and debug statements Adds 2d variable GM and fixes phase speed bug Adds options for 3d varying GM bolus and 2d varying phase speed
Update maint1.2: 3D varying GM This update adds the following PRs from ocean/develop: - Adds options for 3d varying GM bolus and 2d varying phase speed #288 - Add GM bolus eddy stats #339 - Fix threading issue in MPAS-O GM routine #376 - compute landIceMask using geometric_features #447 - bug fixes for the nonlocal source term in KPP #305
#3513) Update maint1.2: add 3D varying GM This update brings in a new mpas-source submodule with the following PRs from MPAS ocean/develop: * Adds options for 3d varying GM bolus and 2d varying phase speed (MPAS-Dev/MPAS-Model#288) * Add GM bolus eddy stats (MPAS-Dev/MPAS-Model#339) * Fix threading issue in MPAS-O GM routine (MPAS-Dev/MPAS-Model#376) * Compute landIceMask using geometric_features (MPAS-Dev/MPAS-Model#447) * Bug fixes for the nonlocal source term in KPP (MPAS-Dev/MPAS-Model#305) and from E3SM master: * Change all ocean output files to single precision (E3SM #3360) [non-BFB]
In the GM bolus calculation, there is a specified diffusivity and phase speed (see Ferrari et al. 2010). Currently MPAS-O assumes these values are fixed in time and space. This PR allows separate flags to enable 2D varying (+time) phase speed (based on the first baroclinic mode phase speed) and a separate flag for 3D (+time) varying diffusivity.
In the GM bolus calculation, there is a specified diffusivity and phase speed (see Ferrari et al. 2010). Currently MPAS-O assumes these values are fixed in time and space. This PR allows separate flags to enable 2D varying (+time) phase speed (based on the first baroclinic mode phase speed) and a separate flag for 3D (+time) varying diffusivity.
5 participants
In the GM bolus calculation, there is a specified diffusivity and phase
speed (see Ferrari et al. 2010). Currently MPAS-O assumes these values
are fixed in time and space. This PR allows separate flags to enable
2D varying (+time) phase speed (based on the first baroclinic mode phase
speed) and a separate flag for 3D (+time) varying diffusivity.