Skip to content

Adds option to directly force tidal boundary #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pwolfram merged 1 commit into from
Jun 21, 2019
Merged

Adds option to directly force tidal boundary #284

pwolfram merged 1 commit into from
Jun 21, 2019

Conversation

@pwolfram
Copy link
Contributor

@pwolfram pwolfram commented Jun 17, 2019

This adds an additional option that allows direct forcing of the tidal boundary, instead
of use of a thickness tendency to apply the tidal boundary.

The test case has been distinguished into these two separate options:

  • thickness_source that uses restoring to apply the tidal boundary condition via a thickness tendency
  • direct that sets the layer thicknesses to obtain a desired sea surface height

@pwolfram pwolfram requested a review from mark-petersen June 17, 2019 19:09
@pwolfram
Copy link
Contributor Author

pwolfram commented Jun 17, 2019

Testing

thickness_source

tidalcomparison

direct

tidalcomparison

Note that the direct approach has a clamped boundary that perfectly respects the applied tidal forcing, whereas the thickness_source approach has the lag as noted in #206

@pwolfram
Copy link
Contributor Author

pwolfram commented Jun 17, 2019

@mark-petersen, note I only implemented this for RK4 because at present because of #217, although we could probably extend this to split explicit without too much trouble. Given that a primary need for this is to support testing of wetting and drying, which is only implemented for RK4 at present, I'm not sure we need to support split explicit to start.

@pwolfram pwolfram mentioned this pull request Jun 17, 2019
Open
@pwolfram
Copy link
Contributor Author

pwolfram commented Jun 18, 2019

Hm, this is interesting @mark-petersen. When I rebased onto ocean/develop the thickness_source approach improved in quality...

tidalcomparison

Did you update the thickness tendency terms anytime recently? The phase lag is decreased, which is great!

@pwolfram pwolfram force-pushed the coastal/clamped_tidal_BC branch from ea4b726 to 29f40d0 Compare June 18, 2019 14:28
@pwolfram
Adds option to directly force with tidal boundary
7fd8c26 
This ensures that exact tidal boundary can be obtained
@pwolfram pwolfram force-pushed the coastal/clamped_tidal_BC branch from 29f40d0 to 7fd8c26 Compare June 18, 2019 14:49
@pwolfram
Copy link
Contributor Author

pwolfram commented Jun 21, 2019

@mark-petersen, this also is needed by the drying slope cases too and it works when incorporated. I'm ready for it to be merged pending your checks (using the drying slope prototype as a half-verification). Note the tidal amplitude is forced on the left side and results are as expected too using the direct approach, much better than the thickness_source:

dryingslopecomparison
tidalcomparison

mark-petersen
mark-petersen approved these changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pwolfram if you are happy with this, go ahead and merge. I will do full testing and bfb comparisons when I merge coastal into ocean/develop.

@pwolfram pwolfram merged commit 7fd8c26 into MPAS-Dev:ocean/coastal Jun 21, 2019
pwolfram added a commit that referenced this pull request Jun 21, 2019
@pwolfram
Merge #284 'pwolfram/coastal/clamped_tidal_BC' into ocean/coastal
b3622a0 
Adds option to directly force with tidal boundary

This ensures that exact tidal boundary can be obtained via
the new 'config_tidal_forcing_type'='direct' option, which is
a direct application of the free surface.
@pwolfram pwolfram deleted the coastal/clamped_tidal_BC branch June 21, 2019 19:29
@pwolfram
Copy link
Contributor Author

pwolfram commented Jun 21, 2019

Thanks @mark-petersen!

@mark-petersen mark-petersen mentioned this pull request Oct 18, 2019
Merged
mark-petersen added a commit that referenced this pull request Oct 19, 2019
@mark-petersen
Merge branch 'ocean/coastal' into ocean/develop
aec7316 
This PR is an accumulation of PRs into the ocean/coastal branch. We are
bringing them in at once for efficiency:
 #285, #289, #284, #295, #310, #311, #312, #335, #354, #356, #358, #359,
 #365, #371
mark-petersen added a commit that referenced this pull request Oct 19, 2019
@mark-petersen
Merge branch 'ocean/develop' into e3sm/develop
75d4cd0 
This PR is an accumulation of PRs into the ocean/coastal branch. We are
bringing them in at once for efficiency.
 #285, #289, #284, #295, #310, #311, #312, #335, #354, #356, #358, #359,
 #365, #371
@xylar xylar mentioned this pull request Apr 8, 2020
Merged
ashwathsv pushed a commit to ashwathsv/MPAS-Model that referenced this pull request Jul 21, 2020
@pwolfram
Merge MPAS-Dev#284 'pwolfram/coastal/clamped_tidal_BC' into ocean/coa…
5d0c59c 
…stal

Adds option to directly force with tidal boundary

This ensures that exact tidal boundary can be obtained via
the new 'config_tidal_forcing_type'='direct' option, which is
a direct application of the free surface.
ashwathsv pushed a commit to ashwathsv/MPAS-Model that referenced this pull request Jul 21, 2020
@mark-petersen
Merge branch 'ocean/coastal' into ocean/develop
5663fac 
This PR is an accumulation of PRs into the ocean/coastal branch. We are
bringing them in at once for efficiency:
 MPAS-Dev#285, MPAS-Dev#289, MPAS-Dev#284, MPAS-Dev#295, MPAS-Dev#310, MPAS-Dev#311, MPAS-Dev#312, MPAS-Dev#335, MPAS-Dev#354, MPAS-Dev#356, MPAS-Dev#358, MPAS-Dev#359,
 MPAS-Dev#365, MPAS-Dev#371
mark-petersen pushed a commit to mark-petersen/MPAS-Model that referenced this pull request Jan 11, 2021
@pwolfram
Merge MPAS-Dev#284 'pwolfram/coastal/clamped_tidal_BC' into ocean/coa…
2163a78 
…stal

Adds option to directly force with tidal boundary

This ensures that exact tidal boundary can be obtained via
the new 'config_tidal_forcing_type'='direct' option, which is
a direct application of the free surface.
mark-petersen added a commit to mark-petersen/MPAS-Model that referenced this pull request Jan 11, 2021
@mark-petersen
Merge branch 'ocean/coastal' into ocean/develop
3a4dc06 
This PR is an accumulation of PRs into the ocean/coastal branch. We are
bringing them in at once for efficiency:
 MPAS-Dev#285, MPAS-Dev#289, MPAS-Dev#284, MPAS-Dev#295, MPAS-Dev#310, MPAS-Dev#311, MPAS-Dev#312, MPAS-Dev#335, MPAS-Dev#354, MPAS-Dev#356, MPAS-Dev#358, MPAS-Dev#359,
 MPAS-Dev#365, MPAS-Dev#371
caozd999 pushed a commit to caozd999/MPAS-Model that referenced this pull request Jan 14, 2021
@mark-petersen
Merge branch 'ocean/coastal' into ocean/develop
18c60ee 
This PR is an accumulation of PRs into the ocean/coastal branch. We are
bringing them in at once for efficiency:
 MPAS-Dev#285, MPAS-Dev#289, MPAS-Dev#284, MPAS-Dev#295, MPAS-Dev#310, MPAS-Dev#311, MPAS-Dev#312, MPAS-Dev#335, MPAS-Dev#354, MPAS-Dev#356, MPAS-Dev#358, MPAS-Dev#359,
 MPAS-Dev#365, MPAS-Dev#371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mark-petersen mark-petersen mark-petersen approved these changes

Assignees

No one assigned

Labels

clean-up coastal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pwolfram @mark-petersen @matthewhoffman