PIO Version Compatibility Check - PGI Compiler Bug Fix #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the bug that made the PGI compiler 18.10 fail upon the PIO version compatibility check. It was able to be fixed by moving the target file to the beginning of the compiler arguments.
MiCurry
force-pushed
the
framework/pio_pgi_fix
branch
from
4621951 to
f2f4fbf
Compare
mgduda
approved these changes
Apr 17, 2019
Contributor
mgduda
left a comment
mgduda
left a comment
There was a problem hiding this comment.
The PGI compiler no longer fails on the PIO version checks in the top-level Makefile, and compilation still works with the Intel and GNU compilers.
Contributor
|
@matthewhoffman @mark-petersen The changes in this PR only update the small test programs that are generated by the top-level Makefile, compiled, then deleted. Accordingly, I think it may not be necessary to run actual model simulations to test these changes. Verifying that the build process still works should be sufficient. |
mark-petersen
approved these changes
Apr 17, 2019
Contributor
mark-petersen
left a comment
mark-petersen
left a comment
There was a problem hiding this comment.
Tested MPAS-Ocean compile with gnu on badger, and it all worked.
Contributor
|
@matthewhoffman Was there any testing of this PR that you'd like to do with the land-ice core specifically? |
matthewhoffman
approved these changes
May 2, 2019
Member
matthewhoffman
left a comment
matthewhoffman
left a comment
There was a problem hiding this comment.
approved by inspection
mgduda
added a commit
that referenced
this pull request
May 2, 2019
This merge fixes a bug in the PIO compatibility check in the top-level Makefile, wherein the PGI compilers failed to build any of the test programs due to the order in which arguments were provided in the compilation command. The simple fix is to move the source file to the front of the compiler arguments. * framework/pio_pgi_fix: PIO Version Compatibility - PGI Bug Fix
mark-petersen
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
May 22, 2019
Includes: 1. LIGHT update (MPAS-Ocean Lagrangian particles): MPAS-Dev/MPAS-Model#56 2. clean up ice shelf melt flag: MPAS-Dev/MPAS-Model#164 3. merge coastal branch: MPAS-Dev/MPAS-Model#54 4. CONUS mesh update: MPAS-Dev/MPAS-Model#201 5. Major COMPASS upgrade to python 3: MPAS-Dev/MPAS-Model#229 6. Eliminate outdated -DUNDERSCORE flag: MPAS-Dev/MPAS-Model#156 7. PIO Version Compatibility Check - PGI Compiler Bug Fix: MPAS-Dev/MPAS-Model#212 These changes do not alter E3SM standard cases or testing on next. COMPASS is the MPAS testing infrastructure. LIGHT and coastal changes are protected by flags and not used in normal E3SM tests.
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
May 22, 2019
Update mpas source This PR update the mpas-source git submodule but only includes changes that will not impact E3SM. These changes include: * LIGHT update (MPAS-Ocean Lagrangian particles): MPAS-Dev/MPAS-Model#56 * clean up ice shelf melt flag: MPAS-Dev/MPAS-Model#164 * merge coastal branch: MPAS-Dev/MPAS-Model#54 * CONUS mesh update: MPAS-Dev/MPAS-Model#201 * Major COMPASS upgrade to python 3: MPAS-Dev/MPAS-Model#229 * Eliminate outdated -DUNDERSCORE flag: MPAS-Dev/MPAS-Model#156 * PIO Version Compatibility Check - PGI Compiler Bug Fix: MPAS-Dev/MPAS-Model#212 These changes do not alter E3SM standard cases or tested configurations. COMPASS is the MPAS testing infrastructure. LIGHT and coastal changes are protected by flags and not used in normal E3SM tests. [NML] [BFB]
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
May 23, 2019
Update mpas source This PR update the mpas-source git submodule but only includes changes that will not impact E3SM. These changes include: * LIGHT update (MPAS-Ocean Lagrangian particles): MPAS-Dev/MPAS-Model#56 * clean up ice shelf melt flag: MPAS-Dev/MPAS-Model#164 * merge coastal branch: MPAS-Dev/MPAS-Model#54 * CONUS mesh update: MPAS-Dev/MPAS-Model#201 * Major COMPASS upgrade to python 3: MPAS-Dev/MPAS-Model#229 * Eliminate outdated -DUNDERSCORE flag: MPAS-Dev/MPAS-Model#156 * PIO Version Compatibility Check - PGI Compiler Bug Fix: MPAS-Dev/MPAS-Model#212 These changes do not alter E3SM standard cases or tested configurations. COMPASS is the MPAS testing infrastructure. LIGHT and coastal changes are protected by flags and not used in normal E3SM tests. [NML] [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the bug addressed in issue #207, that caused the PGI compiler 18.10 to fail upon reaching the PIO version compatibility check. This single commit moves the target file to the front of the compiler arguments, which fixes the problems.