Adds boundary tidal forcing capability #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
TestingA 25km long test case is included that makes a comparison in an analysis step against the forced tidal signal vs the actual MPAS-O free surface:
Note, phase error is observed due to the RK4 time integrator. This is expected behavior. |
Contributor
Author
|
Tested locally and on IC at |
This solves for a layer thickness tendency of the form M*(tidal_boundary - ssh) / tidal_tau * layerThickness/sum_k(layerThickness) where * M is a boundary condition mask for application of the tidal boundary * tidal_boundary is the value of the tide to be applied on the boundary * ssh is the sea surface height * tidal_tau is the time scale corresponding to application of the tendency * layerThickness is the iCell,k varying layerThickness variable * sum_k(layerThickness) is the depth-averaged layerThickness (total water thicknes)
pwolfram
force-pushed
the
ocean/tidal_boundary_condition_forcing
branch
from
7424a26 to
06455bc
Compare
Contributor
Author
|
@caozd999, here is the test case with tidal forcing you need for your sediment transport work as we discussed. |
Contributor
|
Passes nightly regression, bfb with ocean/develop. Of course, that does not exercise the new code. @pwolfram or @caozd999, please compile with DEBUG=true and run with your standard test case to create the new initial condition for tidal forcing and run the forward model with |
Contributor
Author
|
@mark-petersen, thank you. I've compiled and run the case with DEBUG=true and it produces the output as expected. |
mark-petersen
approved these changes
Apr 17, 2019
Contributor
mark-petersen
left a comment
mark-petersen
left a comment
There was a problem hiding this comment.
Looks good thanks!
mark-petersen
added a commit
that referenced
this pull request
Apr 17, 2019
…ocean/coastal This allows restoring of the layerThickness to correspond to relaxation toward a tidally-enforced free-surface boundary condition. Note, this is tested for RK4. Split explicit was not as stable. This solves for a layer thickness tendency of the form M*(tidal_boundary - ssh) / tidal_tau * layerThickness/sum_k(layerThickness) where * M is a boundary condition mask for application of the tidal boundary * tidal_boundary is the value of the tide to be applied on the boundary * ssh is the sea surface height * tidal_tau is the time scale corresponding to application of the * tendency * layerThickness is the iCell,k varying layerThickness variable * sum_k(layerThickness) is the depth-averaged layerThickness (total * water thickness) The tendency is used to apply tidal forcing to the prognostic equations corresponding to a mask designating the location of the applied tidal boundary.
This was referenced Apr 22, 2019
ashwathsv
pushed a commit
to ashwathsv/MPAS-Model
that referenced
this pull request
Jul 21, 2020
…g' into ocean/coastal This allows restoring of the layerThickness to correspond to relaxation toward a tidally-enforced free-surface boundary condition. Note, this is tested for RK4. Split explicit was not as stable. This solves for a layer thickness tendency of the form M*(tidal_boundary - ssh) / tidal_tau * layerThickness/sum_k(layerThickness) where * M is a boundary condition mask for application of the tidal boundary * tidal_boundary is the value of the tide to be applied on the boundary * ssh is the sea surface height * tidal_tau is the time scale corresponding to application of the * tendency * layerThickness is the iCell,k varying layerThickness variable * sum_k(layerThickness) is the depth-averaged layerThickness (total * water thickness) The tendency is used to apply tidal forcing to the prognostic equations corresponding to a mask designating the location of the applied tidal boundary.
mark-petersen
added a commit
to mark-petersen/MPAS-Model
that referenced
this pull request
Jan 11, 2021
…g' into ocean/coastal This allows restoring of the layerThickness to correspond to relaxation toward a tidally-enforced free-surface boundary condition. Note, this is tested for RK4. Split explicit was not as stable. This solves for a layer thickness tendency of the form M*(tidal_boundary - ssh) / tidal_tau * layerThickness/sum_k(layerThickness) where * M is a boundary condition mask for application of the tidal boundary * tidal_boundary is the value of the tide to be applied on the boundary * ssh is the sea surface height * tidal_tau is the time scale corresponding to application of the * tendency * layerThickness is the iCell,k varying layerThickness variable * sum_k(layerThickness) is the depth-averaged layerThickness (total * water thickness) The tendency is used to apply tidal forcing to the prognostic equations corresponding to a mask designating the location of the applied tidal boundary.
caozd999
pushed a commit
to caozd999/MPAS-Model
that referenced
this pull request
Jan 14, 2021
…g' into ocean/coastal This allows restoring of the layerThickness to correspond to relaxation toward a tidally-enforced free-surface boundary condition. Note, this is tested for RK4. Split explicit was not as stable. This solves for a layer thickness tendency of the form M*(tidal_boundary - ssh) / tidal_tau * layerThickness/sum_k(layerThickness) where * M is a boundary condition mask for application of the tidal boundary * tidal_boundary is the value of the tide to be applied on the boundary * ssh is the sea surface height * tidal_tau is the time scale corresponding to application of the * tendency * layerThickness is the iCell,k varying layerThickness variable * sum_k(layerThickness) is the depth-averaged layerThickness (total * water thickness) The tendency is used to apply tidal forcing to the prognostic equations corresponding to a mask designating the location of the applied tidal boundary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows restoring of the layerThickness to correspond to relaxation toward a tidally-enforced free-surface boundary condition. Note, this is tested for RK4. Split explicit was not as stable.
This solves for a layer thickness tendency of the form
M*(tidal_boundary - ssh) / tidal_tau * layerThickness/sum_k(layerThickness)
where
The tendency is used to apply tidal forcing to the prognostic equations corresponding to a mask designating the location of the applied tidal boundary.